Conversation
dagarwal-ecs
left a comment
There was a problem hiding this comment.
One very small update, besides that it looks good
dagarwal-ecs
left a comment
There was a problem hiding this comment.
Looks good from my end
…sterTests.ps1 to /PowerShell/ScubaGear/Testing/Unit/PowerShell/RunPowerShellUnitTests.ps1
…er. also remoed legacy unused script RunFunctionalTests.ps1
81f719d to
e020bca
Compare
DickTracyII
left a comment
There was a problem hiding this comment.
i ran through both scripts. I like the new names
|
@DickTracyII @dagarwal-ecs I am about to push the added enhancement to the functional test orchestrator and update the PR with new test instructions. I will do an official request for re-review when I finish. |
…ifiedProviderSettingsExport.json so developers can reference it when creating functional test scenarios
Testing instructions for the enhancement that keeps a copy of ModifiedProviderSettingsExport.json
Examine the output of a single test scenario and verify that you can see the changes in the saved copy of the ModifiedProviderSettingsExport file.
This proves that the orchestrator saved a copy of the configuration created by the first test scenario "MS.AAD.3.3v2 Not-applicable case - MS Auth Disabled"
Expand to try out more test cases.
Final boss test
|
|
@DickTracyII @dagarwal-ecs I added a description of the new scope at the top of the issue to save you time looking at file diffs and I added custom test instructions to make your life easier. Feel free to do any tests outside of what I put there and I welcome any questions about the code or design. Thanks for your flexibility. Go for it. |
|
@tkol2022 I ran the functional tests like you stated except I include all AAD policies. I did get alot of runtime exceptions...not sure why but it did produce several MOdifiedProviderSettingsExport json files. I'll run more tests next week.
|
Thanks! Looks like the errors are on GCCHigh? Which specific test scenarios are failing so I can reproduce? Did you get any errors on GCC, E5 or G3? @dagarwal-ecs Did you get any errors? |
|
Yes the errors were on gcchigh but I think it was due to my PesterContianer configuration. I didn't receive the errors on any of the tenant after i rebuild my configurations; I had ``TenantDomain |
DickTracyII
left a comment
There was a problem hiding this comment.
Everything tested out fine for GCCHIGH, G3, E5 and functional tests passed!












🗣 Description
Under the Better Coding Act of 2026 I chartered a quick mini-task to improve the names of the scripts RunUnitTests.ps1 and RunPesterTests.ps1. These scripts are now dubbed RunRegoUnitTests.ps1 and RunPowerShellUnitTests.ps1 so that developers have a better clue on what they are for. I also deleted a phantom script RunFunctionalTests.ps1 since nobody uses it. I moved RunPowerShellUnitTests.ps1 into the ./Testing folder since that script is meant for developer use and it makes sense to put developer scripts in a standard folder instead of deep inside the ScubaGear folder tree.
Closes #1989
Added 2/27/2026
Under the Scope Creep Renewal Act of 2026 I decided to add an important fix to the Products.Tests.ps1 file used by the functional test orchestrator whenever scenarios invoke the ScubaCached test type. This particular functional test type is used extensively by the Entra Id test plan and in smaller quantities in the Defender, EXO and PowerPlatform test plans.
The ScubaCached orchestration code had a defect where it deletes the ModifiedProviderSettingsExport file and this prevents a developer from seeing the file that a specific test scenario creates when developing test scenarios. To rectify this I added code that saves a copy of the ModifiedProviderSettingsExport file created by each test scenario right before the file gets deleted.
💭 Motivation and context
Under BCA2026 developers want to spend less time trying to figure out what a specific script is used for, particularly when the script is helpful and commonly used for unit testing their changes.
🧪 Testing Instructions
Use the sample code below to ensure that the scripts work. Execute these from the root ScubaGear folder.
.\Testing\RunRegoUnitTests.ps1 -p aad.\Testing\RunPowerShellUnitTests.ps1✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branchbutton below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Mediumor larger)✅ Post-merge checklist