Skip to content

Create Security Suite baseline#2015

Open
adhilto wants to merge 6 commits intov2.0from
security-suite-baseline
Open

Create Security Suite baseline#2015
adhilto wants to merge 6 commits intov2.0from
security-suite-baseline

Conversation

@adhilto
Copy link
Collaborator

@adhilto adhilto commented Mar 4, 2026

🗣 Description

  • Create the new Security Suite baseline
  • Remove the Defender baseline
  • Update the Teams and EXO baselines, moving applicable controls to the Security Suite baseline

💭 Motivation and context

Closes #1508.
Closes #2017.

🧪 Testing

N/A. Code changes will come later. This is in fact a breaking change and will leave the v2.0 branch in a broken state until the code changes are implemented.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

  • Demonstrate changes to the team for questions and comments.
    (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@adhilto adhilto self-assigned this Mar 4, 2026
@adhilto adhilto added breaking change This issue or pull request involves changes to existing functionality baseline-document Issues relating to the text in the baseline documents themselves labels Mar 4, 2026
@adhilto adhilto linked an issue Mar 4, 2026 that may be closed by this pull request
5 tasks
@FollyBeachGurl FollyBeachGurl added this to the Plankton milestone Mar 5, 2026
@FollyBeachGurl
Copy link
Collaborator

@adhilto since this had no milestone or sprint assigned, I added it to the current one. will need size and priority added.

@skirkpatrickMSFT
Copy link
Collaborator

Alden,

Great work on updating the MD files. I think we need to update the rest of the code to reflect the new control names before committing. Were you still working that?

@adhilto
Copy link
Collaborator Author

adhilto commented Mar 5, 2026

Alden,

Great work on updating the MD files. I think we need to update the rest of the code to reflect the new control names before committing. Were you still working that?

My initial thought was to defer that to #2019 so we could have a review focused on just the baseline changes, but I could add it here instead. There's a bit more work to do, but I'm pretty close to finishing it.

@skirkpatrickMSFT
Copy link
Collaborator

Alden,
Great work on updating the MD files. I think we need to update the rest of the code to reflect the new control names before committing. Were you still working that?

My initial thought was to defer that to #2019 so we could have a review focused on just the baseline changes, but I could add it here instead. There's a bit more work to do, but I'm pretty close to finishing it.

The issue is the tie we have to the MD files and code. Just changing a couple of the Teams controls it its MD to v2 caused me to have to make downstream changes to code. Right now, testing is failing due to the same issue I saw with Teams.

@adhilto
Copy link
Collaborator Author

adhilto commented Mar 5, 2026

Alden,
Great work on updating the MD files. I think we need to update the rest of the code to reflect the new control names before committing. Were you still working that?

My initial thought was to defer that to #2019 so we could have a review focused on just the baseline changes, but I could add it here instead. There's a bit more work to do, but I'm pretty close to finishing it.

The issue is the tie we have to the MD files and code. Just changing a couple of the Teams controls it its MD to v2 caused me to have to make downstream changes to code. Right now, testing is failing due to the same issue I saw with Teams.

Ok, I've made some changes, the pipeline is passing again, ready for review.

Copy link
Collaborator

@skirkpatrickMSFT skirkpatrickMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the markdown files and updating the MD functional tests to allow for them to pass. The updates look good. Looking forward to seeing the follow on work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

baseline-document Issues relating to the text in the baseline documents themselves breaking change This issue or pull request involves changes to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Draft Security Suite baseline text

3 participants