Conversation
|
@adhilto since this had no milestone or sprint assigned, I added it to the current one. will need size and priority added. |
|
Alden, Great work on updating the MD files. I think we need to update the rest of the code to reflect the new control names before committing. Were you still working that? |
My initial thought was to defer that to #2019 so we could have a review focused on just the baseline changes, but I could add it here instead. There's a bit more work to do, but I'm pretty close to finishing it. |
The issue is the tie we have to the MD files and code. Just changing a couple of the Teams controls it its MD to v2 caused me to have to make downstream changes to code. Right now, testing is failing due to the same issue I saw with Teams. |
Ok, I've made some changes, the pipeline is passing again, ready for review. |
skirkpatrickMSFT
left a comment
There was a problem hiding this comment.
Great work on the markdown files and updating the MD functional tests to allow for them to pass. The updates look good. Looking forward to seeing the follow on work
🗣 Description
💭 Motivation and context
Closes #1508.
Closes #2017.
🧪 Testing
N/A. Code changes will come later. This is in fact a breaking change and will leave the v2.0 branch in a broken state until the code changes are implemented.
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branchbutton below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Mediumor larger)✅ Post-merge checklist