fix: emit securitysuite in New-SCuBAConfig samples - #2287
Open
l46983284-cpu wants to merge 1 commit into
Open
Conversation
New-SCuBAConfig still defaulted ProductNames to defender and wrote a Defender section. Align the helper with ScubaConfigDefaults and the Security Suite config namespace, keep defender as a legacy alias, and scaffold MS.SECURITYSUITE.2.1v1 / 2.3v1 sample values. Signed-off-by: Alex Chen <l46983284@gmail.com>
1 task
Collaborator
|
@DickTracyII will reference this PR in a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
New-SCuBAConfigstill defaultedProductNamesto the legacydefenderproduct and wrote a top-levelDefendersection with oldMS.DEFENDER.*policy keys. The rest of ScubaGear already treats Security Suite assecuritysuite/SecuritySuite(defaults, orchestrator, docs, sample configs).This change:
securitysuitedefenderonly as a legacy alias and normalizes it tosecuritysuiteMS.SECURITYSUITE.2.1v1,MS.SECURITYSUITE.2.3v1) under aSecuritySuitesection💭 Motivation and context
Proposed Solution for #2285.
Anyone bootstrapping from
New-SCuBAConfigwas still landing on the deprecated product name and config namespace, which diverges fromScubaConfigDefaultsand the Security Suite configuration docs.🧪 Testing
New-SCuBAConfig.Tests.ps1for securitysuite defaults, legacydefenderalias normalization, and modern omit-policy examples.✅ Pre-approval checklist
✅ Pre-merge checklist
Squash and mergebutton.