Skip to content

fix: emit securitysuite in New-SCuBAConfig samples - #2287

Open
l46983284-cpu wants to merge 1 commit into
cisagov:mainfrom
l46983284-cpu:fix/new-scubaconfig-securitysuite-2285
Open

fix: emit securitysuite in New-SCuBAConfig samples#2287
l46983284-cpu wants to merge 1 commit into
cisagov:mainfrom
l46983284-cpu:fix/new-scubaconfig-securitysuite-2285

Conversation

@l46983284-cpu

@l46983284-cpu l46983284-cpu commented Jul 20, 2026

Copy link
Copy Markdown

🗣 Description

New-SCuBAConfig still defaulted ProductNames to the legacy defender product and wrote a top-level Defender section with old MS.DEFENDER.* policy keys. The rest of ScubaGear already treats Security Suite as securitysuite / SecuritySuite (defaults, orchestrator, docs, sample configs).

This change:

  • defaults generated configs to securitysuite
  • accepts defender only as a legacy alias and normalizes it to securitysuite
  • scaffolds the current Security Suite config keys (MS.SECURITYSUITE.2.1v1, MS.SECURITYSUITE.2.3v1) under a SecuritySuite section
  • updates the unit tests to cover the modern defaults and the alias path

💭 Motivation and context

Proposed Solution for #2285.

Anyone bootstrapping from New-SCuBAConfig was still landing on the deprecated product name and config namespace, which diverges from ScubaConfigDefaults and the Security Suite configuration docs.

🧪 Testing

  • Updated New-SCuBAConfig.Tests.ps1 for securitysuite defaults, legacy defender alias normalization, and modern omit-policy examples.
  • Host note: this VPS has no PowerShell/Pester runtime. Product-path static assertions on the patched function and tests all pass (ValidateSet, default ProductNames, SecuritySuite section, MS.SECURITYSUITE policy keys, alias rewrite, brace balance).

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • Functional tests added/updated to cover PowerShell and Rego changes.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.
  • Feature branch has been rebased against changes from parent branch, as needed.
  • Resolved all merge conflicts on branch.
  • Squash all commits into one PR level commit using the Squash and merge button.

New-SCuBAConfig still defaulted ProductNames to defender and wrote a
Defender section. Align the helper with ScubaConfigDefaults and the
Security Suite config namespace, keep defender as a legacy alias, and
scaffold MS.SECURITYSUITE.2.1v1 / 2.3v1 sample values.

Signed-off-by: Alex Chen <l46983284@gmail.com>
@dagarwal-ecs dagarwal-ecs added the public-reported This issue is reported by the public users of the tool. label Jul 20, 2026
@FollyBeachGurl

Copy link
Copy Markdown
Collaborator

@DickTracyII will reference this PR in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

public-reported This issue is reported by the public users of the tool.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants