Conversation
mitchelbaker-cisa
left a comment
There was a problem hiding this comment.
Looks good, tested with an additional domain that had two DMARC records. Gmail 4.1-4.4 collectively fail if two DMARC records are set, pass if one DMARC record is set with all required fields.
One addition I think would be helpful is clarifying text in the report details column to indicate a domain is failing because two records are set. E.g., "2 DMARC records are set for somedomain.com. See DMARC table below for more details."
|
Tested SPF updates as well, fails for two SPF records and passes when one field is correctly set. |
I'll defer the SPF one for the issue we have for improving the report details for SPF. |

🗣 Description
Make it so that the SCuBA Gmail policies relating to DMARC and SPF will fail if multiple DMARC records are returned.
I also tweaked the DNS table formatting so that it's a little easier to see when a query returns multiple DNS records.
💭 Motivation and context
Closes #849
🧪 Testing
Reviewers should:
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and mergebutton.✅ Post-merge Checklist