Fix Side Drawer Advance Filters (CRASM-967)#740
Merged
Conversation
- Added sort to portFacet. - Added sort to cveFacet. - Severity levels are now sorted in order of Low, Medium, High, Critical.
- npm run syncdb was not syncing domains on run due to it being nested inside syncdb -- -d populate. -- Thus changes to local db were not being reflected in the search index. - Edited severityFacet logic to only show severity filters if there are severity filters to show. - Added a sort to display severity filters in the following order: N/A, Low, Medium, High, Critical, Other.
- Added data validation logic to group irregular severity values into appropriate categories. - Null, empty string, N/A, and undefined values are grouped into the "N/A" category. - Special characters, numbers, and Other are grouped into the "Other" category. - All categories are case insensitive. - Edited vulnerability.severity agg in buildRequest.ts to inclues "null" values. - Increased aggregation size to 50 to include all severity values.
- Removed console.logs. - Removed commented out code.
- Now includes permutations of NUll, N/A, empty string, and undefined values.
- Added "aggregations" to the search endpoint result. - Updated SearchResponse Base Model to include aggregations.
- severity filter values are forced to be lowercase. - N/A value returns Null, N/A, None, undefined, and empty strings. - Other returns all other values not included in N/A or regular severity level values.
hawkishpolicy
changed the title
hawkishpolicy
requested review from
Matthew-Grayson,
aloftus23,
cduhn17,
nickviola,
rapidray12 and
schmelz21
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Vulnerabilities.cve were not included in the searchSync handler that updates Elastic Search. They are now. - Added some random CVE's for sample data population to aid in testing.
schmelz21
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies a more user friendly and consistent display, plus increased functionality, to the checkbox controlled filters in the Advanced Filters section of the Side Drawer.
🗣 Description
💭 Motivation and context
🧪 Testing
📷 Screenshots (if appropriate)
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist