Move CSP and HSTS definitions to settings.py#760
Merged
Conversation
We don't want to use f-strings anywhere as they create potential vulnerabilities
cduhn17
approved these changes
Jan 15, 2025
Collaborator
cduhn17
left a comment
There was a problem hiding this comment.
Looks good will be nice to have all of this centralized at settings.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Move CSP and HSTS definitions to settings.py.
This allows security definitions to be more centralized in one location and follows Django standards.
Also the remediates the Checkmarx medium vulnerability in settings.py. This was a false positive, but it did lead us to the idea that these definitions should be in settings.py.
💭 Motivation and context
Medium Checkmarx vulnerability and cleanup.
🧪 Testing
Passes pre-commit checks and pytests.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist