Skip to content

Refactored Orgs page for Global View users#782

Merged
schmelz21 merged 2 commits intodevelopfrom
Fix-Organizations-Page-for-Global-View-CRASM-1062
Feb 11, 2025
Merged

Refactored Orgs page for Global View users#782
schmelz21 merged 2 commits intodevelopfrom
Fix-Organizations-Page-for-Global-View-CRASM-1062

Conversation

@hawkishpolicy
Copy link
Contributor

@hawkishpolicy hawkishpolicy commented Jan 30, 2025 •
edited
Loading

  • Enabled Global View users to "view only" permissions of Organization Settings and Members.

🗣 Description

  • Edited organization.py to allow Global View users to view all organizations.
  • Edited OrgMembers.tsx and OrgSettings.tsx to prevent Global View users from editing organizations or members.
    • Added disabled prop based on user type of Global View to all buttons and inputs in OrgMembers.tsx and OrgSettings.tsx.

💭 Motivation and context

  • Allows Global View users to view but not edit Organizations nor members of said Organizations.
  • Closes CRASM-1062

🧪 Testing

  • Tested locally as a Global View user.

📷 Screenshots (if appropriate)

Screenshot 2025-01-30 at 4 39 52 PM Screenshot 2025-01-30 at 4 39 19 PM Screenshot 2025-01-30 at 4 39 27 PM

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • [x ] Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy
Refactored Orgs page for Global View users
01267cf 
- Edited organization.py to allow Global View users to view all organizations.
- Edited OrgMembers.tsx and OrgSettings.tsx to prevent Global View users from editing organizations or members.
    - Added disabled prop based on user type of Global View to all buttons and inputs in OrgMembers.tsx and OrgSettings.tsx.
@hawkishpolicy hawkishpolicy self-assigned this Jan 30, 2025
@hawkishpolicy
Removed test_get_org_by_global_view_fails
2f005a2 
- Changes to Global View user's ability to view organizations negates the need for this test.
@hawkishpolicy hawkishpolicy marked this pull request as ready for review January 31, 2025 18:11
chrtorres
chrtorres approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 9834bb3 into develop Feb 11, 2025
18 of 19 checks passed
@schmelz21 schmelz21 deleted the Fix-Organizations-Page-for-Global-View-CRASM-1062 branch February 11, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schmelz21 schmelz21 schmelz21 approved these changes

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

+1 more reviewer

@chrtorres chrtorres chrtorres approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hawkishpolicy hawkishpolicy

Labels

backend frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hawkishpolicy @schmelz21 @chrtorres