Skip to content

Separate staging and staging-cd domain name declaration#791

Merged
schmelz21 merged 2 commits intodevelopfrom
AL-fix-build
Feb 10, 2025
Merged

Separate staging and staging-cd domain name declaration#791
schmelz21 merged 2 commits intodevelopfrom
AL-fix-build

Conversation

@aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Feb 10, 2025

🗣 Description

Separate staging and staging-cd domain name declaration

💭 Motivation and context

Terraform breaks when there's a conflict creating the staging/DOMAIN parameter in systems manager.

🧪 Testing

Passes pre-commits and terraform plan.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@schmelz21 schmelz21 merged commit 2a8acc0 into develop Feb 10, 2025
17 of 18 checks passed
@schmelz21 schmelz21 deleted the AL-fix-build branch February 10, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants