Skip to content

CRASM-2321: Update Shodan to save to the MDL and use P&E logic#835

Merged
rapidray12 merged 11 commits intodevelopfrom
AL-add-shodan
Apr 9, 2025
Merged

CRASM-2321: Update Shodan to save to the MDL and use P&E logic#835
rapidray12 merged 11 commits intodevelopfrom
AL-add-shodan

Conversation

@aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Apr 3, 2025

🗣 Description

Update Shodan to save to the MDL and use P&E logic

💭 Motivation and context

Streamline how we pull data from shodan and make sure it's running efficiently with SQS.

🧪 Testing

Passes pre-commit and pytests.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@aloftus23 aloftus23 marked this pull request as ready for review April 8, 2025 20:09
@aloftus23 aloftus23 changed the title Update Shodan to save to the MDL and use P&E logic CRASM-2321: Update Shodan to save to the MDL and use P&E logic Apr 8, 2025
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed in a group meeting

@rapidray12 rapidray12 merged commit 74cbb7d into develop Apr 9, 2025
14 of 15 checks passed
@rapidray12 rapidray12 deleted the AL-add-shodan branch April 9, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants