Skip to content

Fix Inventory Result Scrolling (CRASM-2209)#849

Merged
rapidray12 merged 2 commits intodevelopfrom
Fix-Inventory-Search-Results-Scrolling-CRASM-2209
Apr 9, 2025
Merged

Fix Inventory Result Scrolling (CRASM-2209)#849
rapidray12 merged 2 commits intodevelopfrom
Fix-Inventory-Search-Results-Scrolling-CRASM-2209

Conversation

@hawkishpolicy
Copy link
Contributor

  • Refactor DOM and CSS to allow scrolling of Result Cards if cursor is left or right of card list.

🗣 Description

  • Users can now scroll if cursor is outside of the div.
  • Pagination and Filter bar remain fixed.

💭 Motivation and context

  • Closes CRASM-2209

🧪 Testing

  • Tested locally

📷 Screenshots (if appropriate)

Screen.Recording.2025-04-08.at.1.05.03.PM.mov

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

- Users can now scroll if cursor is outside of the div.
- Pagination and Filter bar remain fixed.
Copy link
Contributor

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed in a group meeting

@rapidray12 rapidray12 merged commit 2b0037f into develop Apr 9, 2025
15 of 16 checks passed
@rapidray12 rapidray12 deleted the Fix-Inventory-Search-Results-Scrolling-CRASM-2209 branch April 9, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants