Skip to content

2665-Update blocklist system #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jayjaybunce
Copy link
Collaborator

🗣 Description

  • Updated the blocklist scan to not delete records unless they are more than 30 days old without an update, using the updated_at field to perform this.
  • Updated the blocklist scan to correctly update the updated_at field when updates are made to the record.
  • Wrote code to prune the records within the scan that meet the above criteria

💭 Motivation and context

Per my conversation with Alex and Ray an issue was mentioned that with the current implementation, our accuracy is not to standard.
Resolves CRASM-2665

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@jayjaybunce jayjaybunce marked this pull request as ready for review May 21, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant