Skip to content

⚠️ CONFLICT! Lineage pull request for: skeleton#899

Merged
mcdonnnj merged 5 commits intodevelopfrom
lineage/skeleton
Sep 25, 2025
Merged

⚠️ CONFLICT! Lineage pull request for: skeleton#899
mcdonnnj merged 5 commits intodevelopfrom
lineage/skeleton

Conversation

@cisagovbot
Copy link

@cisagovbot cisagovbot commented Sep 24, 2025

Lineage Pull Request: CONFLICT

Achtung!!!

Lineage has created this pull request to incorporate new changes found in an upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-generic.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with your project.

The lineage/skeleton branch has one or more unresolved merge conflicts that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/cyhy_amis.git cyhy_amis
    cd cyhy_amis
    git remote add skeleton https://github.com/cisagov/skeleton-generic.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the branch, commit, and push your changes:

    git add .github/labeler.yml 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message that git creates for you, but please do not delete the existing content. It provides useful information about the merge that is being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

Remove any of the following that do not apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • ✌️ The conflicts in this pull request have been resolved.
  • All relevant type-of-change labels have been added.
  • All new and existing tests pass.

Note

You are seeing this because one of this repository's maintainers has configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 3 commits September 19, 2025 16:03
This adds labels that are common in downstream repositories to the core
configuration. This will help ensure consistent label availability.
Add a configuration to automatically apply the `docker` label to pull
requests.
Add more repository labels and expand the auto-labeling configuration
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Sep 24, 2025
These comments have been left in other downstream projects so we should
restore them here for consistency.
@mcdonnnj mcdonnnj marked this pull request as ready for review September 24, 2025 22:36
@mcdonnnj mcdonnnj requested review from a team and Copilot September 24, 2025 22:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a lineage pull request that incorporates upstream changes from the skeleton-generic repository, specifically adding Docker label support and improving configuration comments. The PR had merge conflicts that have been resolved.

  • Added Docker label configuration to support Docker-related pull requests
  • Enhanced labeler configuration with clarifying comments for different technology stacks
  • Resolved merge conflicts as indicated by the "CONFLICT!" title

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/labels.yml Added new Docker label definition for Docker-related pull requests
.github/labeler.yml Added Docker labeler configuration (commented out) and clarifying comments for technology stack sections

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to update the version tags for cisagov/setup-env-github-action, actions/setup-python, and actions/checkout here? Aren't those part of the upstream changes?

@mcdonnnj
Copy link
Member

Do you need to update the version tags for cisagov/setup-env-github-action, actions/setup-python, and actions/checkout here? Aren't those part of the upstream changes?

Since this descends directly from cisagov/skeleton-generic those changes were already merged during the last top-level wave in #896.

@mcdonnnj mcdonnnj merged commit a5bddf2 into develop Sep 25, 2025
19 checks passed
@mcdonnnj mcdonnnj deleted the lineage/skeleton branch September 25, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream update This issue or pull request pulls in upstream updates

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants