Skip to content

Conversation

@jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 6, 2024

πŸ—£ Description

This pull request modernizes setup.py to agree with cisagov/skeleton-python-library.

πŸ’­ Motivation and context

Resolves #107.

πŸ§ͺ Testing

All automated tests pass.

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use python Pull requests that update Python code labels Nov 6, 2024
@jsf9k jsf9k self-assigned this Nov 6, 2024
@jsf9k jsf9k marked this pull request as ready for review November 6, 2024 15:47
@jsf9k jsf9k requested a review from a team November 6, 2024 15:47
@jsf9k jsf9k merged commit 6222390 into develop Nov 6, 2024
4 checks passed
@jsf9k jsf9k deleted the improvement/modernize-setup branch November 6, 2024 17:03
"Tracker": "https://github.com/cisagov/development-guide/issues",
},
# Author details
author="Cyber and Infrastructure Security Agency",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
author="Cyber and Infrastructure Security Agency",
author="Cybersecurity and Infrastructure Security Agency",

@jsf9k jsf9k mentioned this pull request Nov 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement This issue or pull request will add or improve functionality, maintainability, or ease of use python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security auditing detected exec( ) use in setup.py

5 participants