Fix RNG reuse in ENIP generateId() - #108
Open
mmguero wants to merge 1 commit into
Open
Conversation
Hoist random_device/mt19937/uniform_int_distribution out of the per-byte loop into function-static locals, constructed once instead of on every iteration. Fixes both a perf issue (repeated entropy syscalls) and a correctness risk: random_device may fall back to a deterministic sequence on some platforms, which combined with per-iteration re-seeding could produce identical bytes across the whole ID. Safe as static (not thread_local) since Zeek's packet analysis path is single-threaded. Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
mmguero
marked this pull request as ready for review
July 16, 2026 21:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoist random_device/mt19937/uniform_int_distribution out of the per-byte loop into function-static locals, constructed once instead of on every iteration. Fixes both a perf issue (repeated entropy syscalls) and a correctness risk: random_device may fall back to a deterministic sequence on some platforms, which combined with per-iteration re-seeding could produce identical bytes across the whole ID. Safe as static (not thread_local) since Zeek's packet analysis path is single-threaded.