Skip to content

⚠️ CONFLICT! Lineage pull request for: skeleton#58

Merged
jsf9k merged 26 commits intodevelopfrom
lineage/skeleton
Mar 19, 2026
Merged

⚠️ CONFLICT! Lineage pull request for: skeleton#58
jsf9k merged 26 commits intodevelopfrom
lineage/skeleton

Conversation

@cisagovbot
Copy link

@cisagovbot cisagovbot commented Mar 17, 2026

Lineage Pull Request: CONFLICT

Achtung!!!

Lineage has created this pull request to incorporate new changes found in an upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-tf-module.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with your project.

The lineage/skeleton branch has one or more unresolved merge conflicts that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/provisionaccount-role-tf-module.git provisionaccount-role-tf-module
    cd provisionaccount-role-tf-module
    git remote add skeleton https://github.com/cisagov/skeleton-tf-module.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the branch, commit, and push your changes:

    git add README.md examples/basic_usage/README.md 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message that git creates for you, but please do not delete the existing content. It provides useful information about the merge that is being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

  • ✌️ The conflicts in this pull request have been resolved.
  • All relevant type-of-change labels have been added.
  • All new and existing tests pass.

Note

You are seeing this because one of this repository's maintainers has configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

dependabot bot and others added 23 commits December 15, 2025 18:26
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v4...v5)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
The `pull_request` trigger's default activity types are `opened`,
`reopened`, and `synchronized`. These types better represent when we
want this workflow to run and the `edited` type was resulting in
undesired workflow runs.
This is done automatically with the `pre-commit autoupdate` command.
The latest release supports the artifact-metadata permission that we
are now using in the generate-sbom job of the build.yml GitHub Actions
workflow in cisagov/skeleton-aws-lambda-python,
cisagov/skeleton-docker, and cisagov/skeleton-python-library.
This will return the cache key to being a string with no new lines.
It is no longer necessary to install wheel alongside setuptools as of
setuptools v70.1:
https://github.com/pypa/wheel?tab=readme-ov-file#historical-note
This is done automatically with the pre-commit autoupdate command.
We rely on the default activity types for the pull_request event in our
GitHub Actions workflows. This adds a comment mentioning that we do so
and linking to the GitHub documentation for the event which details the
specific activity types that are used by default.

Co-authored-by: dav3r <david.redmin@gwe.cisa.dhs.gov>
This is done automatically with the pre-commit autoupdate command.
Remove installation of `wheel` Python package
…ggers

Adjust the activity types for the `pull_request` trigger in the `Label pull requests` workflow
…ting

Adjust the `lint` job of the `build` workflow's cache key formatting
This gets rid of several errors from our markdownlint pre-commit
linter.
Now that I have two pull requests out for changes relevant to our work
it makes sense to use a branch that consolidates any changes we need.
We need to update the comment about using a branch of mcdonnnj's
terraform-docs fork to reflect that a second PR with different
functionality is now included in the branch.

Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
…s_branch

Change the branch we use for installing terraform-docs
Lineage pull request for: skeleton
Bumps [hashicorp/aws](https://github.com/hashicorp/terraform-provider-aws) from 6.15.0 to 6.30.0.
- [Release notes](https://github.com/hashicorp/terraform-provider-aws/releases)
- [Changelog](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md)
- [Commits](hashicorp/terraform-provider-aws@v6.15.0...v6.30.0)

---
updated-dependencies:
- dependency-name: hashicorp/aws
  dependency-version: 6.30.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…sic_usage/hashicorp/aws-6.30.0

Bump hashicorp/aws from 6.15.0 to 6.30.0 in /examples/basic_usage
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Mar 17, 2026
@github-actions github-actions bot added documentation This issue or pull request improves or adds to documentation dependencies Pull requests that update a dependency file labels Mar 17, 2026
@github-actions github-actions bot added github-actions Pull requests that update GitHub Actions code shell script Pull requests that update shell scripts labels Mar 17, 2026
# Conflicts:
#	README.md
#	examples/basic_usage/README.md
@jsf9k jsf9k force-pushed the lineage/skeleton branch from 6b6d8b9 to 2376659 Compare March 17, 2026 19:35
@jsf9k jsf9k marked this pull request as ready for review March 17, 2026 19:40
Copilot AI review requested due to automatic review settings March 17, 2026 19:40
@jsf9k jsf9k enabled auto-merge March 17, 2026 19:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates repo maintenance/tooling: Python bootstrap dependencies, pre-commit hook versions, GitHub Actions workflow triggers/caching, and regenerates Terraform docs output formatting (Markdown tables / terraform-docs fork branch).

Changes:

  • Remove wheel from bootstrap installs and requirements; tighten setuptools requirement.
  • Refresh generated Terraform-docs Markdown table delimiter formatting in READMEs and update example .terraform.lock.hcl.
  • Bump multiple pre-commit hook versions and adjust GitHub Actions workflows (default PR event types, cache action version/formatting, terraform-docs fork branch name).

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
setup-env Updates pip bootstrap install set (drops wheel).
requirements.txt Removes wheel and pins setuptools minimum version.
README.md Regenerates TF docs Markdown tables with spaced delimiter rows.
examples/basic_usage/README.md Regenerates TF docs output for the example.
examples/basic_usage/.terraform.lock.hcl Updates locked AWS provider version/hashes.
.pre-commit-config.yaml Bumps hook revisions across linters/formatters/security tools.
.github/workflows/label-prs.yml Uses default pull_request activity types (removes explicit list) and documents intent.
.github/workflows/dependency-review.yml Documents using default pull_request activity types.
.github/workflows/codeql-analysis.yml Documents using default pull_request activity types.
.github/workflows/build.yml Updates terraform-docs fork branch, cache action version, and reformats cache key construction.
Files not reviewed (1)
  • examples/basic_usage/.terraform.lock.hcl: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

jsf9k added 2 commits March 17, 2026 16:32
This example code has no providers.
@github-actions github-actions bot added the terraform Pull requests that update Terraform code label Mar 17, 2026
@jsf9k jsf9k merged commit c1f0a4b into develop Mar 19, 2026
13 checks passed
@jsf9k jsf9k deleted the lineage/skeleton branch March 19, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation This issue or pull request improves or adds to documentation github-actions Pull requests that update GitHub Actions code shell script Pull requests that update shell scripts terraform Pull requests that update Terraform code upstream update This issue or pull request pulls in upstream updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants