Skip to content

Bump node from 20 to 24#107

Open
mcdonnnj wants to merge 2 commits intodevelopfrom
maintenance/bump_node_from_20_to_24
Open

Bump node from 20 to 24#107
mcdonnnj wants to merge 2 commits intodevelopfrom
maintenance/bump_node_from_20_to_24

Conversation

@mcdonnnj
Copy link
Member

🗣 Description

This pull request updates the action from the node20 runtime to the the node24 runtime.

💭 Motivation and context

Node.js 20 actions are deprecated and we get a warning in workflow runs that use them. Since this is one of our actions we need to update it to a newer Node.js version, and it makes sense to use the latest we can.

Note

I ran npm run package just to be sure but there were no changed to the distribution code.

🧪 Testing

Automated tests pass. I used this branch in a test branch and the run can be found here: https://github.com/cisagov/skeleton-generic/actions/runs/23249065398/job/67585710219.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@mcdonnnj mcdonnnj requested a review from Copilot March 18, 2026 14:39
@mcdonnnj mcdonnnj self-assigned this Mar 18, 2026
@mcdonnnj mcdonnnj requested review from dav3r, felddy and jsf9k as code owners March 18, 2026 14:39
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Mar 18, 2026
@github-actions github-actions bot added version bump This issue or pull request increments the version number dependencies Pull requests that update a dependency file labels Mar 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s JavaScript GitHub Action to target a newer Node.js runtime and aligns the Node engine/version metadata used for packaging and releases.

Changes:

  • Update action.yml runtime from node20 to node24.
  • Raise the Node.js engine requirement to >=24.
  • Bump the project version from 1.2.1 to 2.0.0 (and sync in package-lock.json).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
action.yml Switches the action runtime to node24.
package.json Updates Node engine requirement and bumps version to 2.0.0.
package-lock.json Syncs version/engine metadata with package.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@mcdonnnj mcdonnnj mentioned this pull request Mar 18, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants