Adjust the bump-version script to use npm functionality#113
Merged
Conversation
Change the script to use npm's built-in functionality for updating a package's version. This will ensure that any npm package files are updated to the new version. However, we do prevent npm from creating the commit and a tag.
mcdonnnj
added
the
improvement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s bump-version helper script to rely on npm’s built-in versioning behavior so that npm-managed package files (notably package-lock.json) get updated consistently.
Changes:
- Extend the versioned/staged file set to include
package-lock.json. - Replace the manual
sed-based version rewrite withnpm version --no-git-tag-version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsf9k
approved these changes
Apr 8, 2026
dav3r
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adjusts the
bump-versionscript to usenpmto change the version in package files.💭 Motivation and context
I noticed that the
bump-versionscript at present does not update the version of the package in thepackage-lock.jsonfile. While I initially considered just adding that file to the list, I thought it might be beneficial to usenpm's built-in functionality to change a package's version. This will ensure that any package files that need to reflect the new version are updated accordingly.🧪 Testing
Automated tests pass. I did some test version bumps and everything looked as one would expect.
✅ Pre-approval checklist