Skip to content

Add a Docker volume at /var/lib/containerd#254

Open
jsf9k wants to merge 1 commit intodevelopfrom
bugfix/add-containerd-volume
Open

Add a Docker volume at /var/lib/containerd#254
jsf9k wants to merge 1 commit intodevelopfrom
bugfix/add-containerd-volume

Conversation

@jsf9k
Copy link
Copy Markdown
Member

@jsf9k jsf9k commented Feb 3, 2026

🗣 Description

This pull request adds a Docker volume at /var/lib/containerd for all platforms tested via molecule.

💭 Motivation and context

This is necessary because of the new containerd snapshotters. Note that the volume that has to be created is at /var/lib/containerd instead of /var/lib/docker. I confirmed that this is also the correct location for Amazon Linux 2023, Fedora 42, and Fedora 43.

🧪 Testing

All automated tests pass. See also cisagov/ansible-role-guacamole#86.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

This is necessary because of the new containerd snapshotters as
described here:
docker/cli#6646 (comment)

Note that the volume that has to be created is at /var/lib/containerd
instead of /var/lib/docker for the reason described here:
docker/cli#6646 (comment)
@jsf9k jsf9k self-assigned this Feb 3, 2026
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Feb 3, 2026
@jsf9k jsf9k added this to Next Kraken Feb 3, 2026
@jsf9k jsf9k moved this to In Progress in Next Kraken Feb 3, 2026
@jsf9k jsf9k moved this from In progress to Review in progress in Skeleton Maintenance Feb 3, 2026
@github-actions github-actions bot added the test This issue or pull request adds or otherwise modifies test code label Feb 3, 2026
@jsf9k jsf9k marked this pull request as ready for review February 3, 2026 22:04
Copy link
Copy Markdown
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ⚛️

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated Docker volume mount for /var/lib/containerd in the shared Molecule Docker platform configuration, ensuring Docker-in-Docker/containerd snapshotter behavior works consistently across all Molecule-tested OS images.

Changes:

  • Add an anonymous Docker volume mounted at /var/lib/containerd to the common Molecule Docker platform config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cisagovbot pushed a commit that referenced this pull request Mar 26, 2026
Install the `go-critic` command instead of `gocritic` in the `build.yml` workflow
@github-project-automation github-project-automation bot moved this from Review in progress to Reviewer approved in Skeleton Maintenance Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This issue or pull request addresses broken functionality kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release test This issue or pull request adds or otherwise modifies test code

Projects

Status: In Progress
Status: Reviewer approved

Development

Successfully merging this pull request may close these issues.

4 participants