Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d873ba4
Bump actions/cache from 4 to 5
dependabot[bot] Dec 15, 2025
ce44624
Remove itemized `pull_request` trigger types
mcdonnnj Jan 15, 2026
9c0d2b6
Update pre-commit hook versions
mcdonnnj Jan 23, 2026
8cff529
Upgrade to the latest release of the check-jsonschema pre-commit hook
jsf9k Jan 26, 2026
77f204a
Adjust the `build` workflow's cache key formatting
mcdonnnj Feb 6, 2026
2fb5133
Remove installation of wheel Python package
jsf9k Feb 13, 2026
6b9b731
Update pre-commit hook versions
jsf9k Feb 19, 2026
f55ce6a
Add a comment mentioning we use defaults
mcdonnnj Feb 19, 2026
57ee431
Update pre-commit hook versions
mcdonnnj Feb 19, 2026
7d62b5e
Merge pull request #249 from cisagov/improvement/remove-wheel
mcdonnnj Feb 20, 2026
9eac052
Merge pull request #244 from cisagov/dependabot/github_actions/action…
mcdonnnj Feb 20, 2026
fe7eb42
Merge pull request #245 from cisagov/improvement/adjust_label-prs_tri…
mcdonnnj Feb 20, 2026
ace1712
Merge pull request #247 from cisagov/improvement/fix_cache_key_format…
mcdonnnj Feb 20, 2026
6ae498b
Merge pull request #246 from cisagov/maintenance/update_pre-commit_hooks
mcdonnnj Feb 20, 2026
9835f28
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Feb 20, 2026
f1e8078
Adjust table entries to match compact style
jsf9k Feb 20, 2026
44f5b28
Change the branch used for terraform-docs
mcdonnnj Feb 21, 2026
4991be5
Update comment in the `build` workflow
mcdonnnj Feb 23, 2026
5df67a7
Merge pull request #250 from cisagov/improvement/change_terraform-doc…
jsf9k Feb 24, 2026
7681734
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
Feb 25, 2026
4dd85ed
Merge pull request #276 from cisagov/lineage/skeleton
jsf9k Mar 16, 2026
b030808
Bump hashicorp/aws from 6.15.0 to 6.30.0 in /examples/basic_usage
dependabot[bot] Mar 16, 2026
a56d4c9
Merge pull request #275 from cisagov/dependabot/terraform/examples/ba…
jsf9k Mar 16, 2026
ebba468
Merge remote-tracking branch 'skeleton/develop' into lineage/skeleton
jsf9k Mar 17, 2026
61864a7
Fix merge error
jsf9k Mar 17, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on: # yamllint disable-line rule:truthy
merge_group:
types:
- checks_requested
# We use the default activity types for the pull_request event as specified here:
# https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request
pull_request:
push:
repository_dispatch:
Expand All @@ -23,7 +25,7 @@ env:
PIP_CACHE_DIR: ~/.cache/pip
PRE_COMMIT_CACHE_DIR: ~/.cache/pre-commit
RUN_TMATE: ${{ secrets.RUN_TMATE }}
TERRAFORM_DOCS_REPO_BRANCH_NAME: improvement/support_atx_closed_markdown_headers
TERRAFORM_DOCS_REPO_BRANCH_NAME: cisagov
TERRAFORM_DOCS_REPO_DEPTH: 1
TERRAFORM_DOCS_REPO_URL: https://github.com/mcdonnnj/terraform-docs.git

Expand Down Expand Up @@ -118,18 +120,20 @@ jobs:
name: Lookup Go cache directory
run: |
echo "dir=$(go env GOCACHE)" >> $GITHUB_OUTPUT
- uses: actions/cache@v4
- uses: actions/cache@v5
env:
BASE_CACHE_KEY: ${{ github.job }}-${{ runner.os }}-\
py${{ steps.setup-python.outputs.python-version }}-\
go${{ steps.setup-go.outputs.go-version }}-\
packer${{ steps.setup-env.outputs.packer-version }}-\
tf${{ steps.setup-env.outputs.terraform-version }}-
BASE_CACHE_KEY: >-
${{ github.job }}-${{ runner.os
}}-py${{ steps.setup-python.outputs.python-version
}}-go${{ steps.setup-go.outputs.go-version
}}-packer${{ steps.setup-env.outputs.packer-version
}}-tf${{ steps.setup-env.outputs.terraform-version }}-
with:
key: ${{ env.BASE_CACHE_KEY }}\
${{ hashFiles('**/requirements-test.txt') }}-\
${{ hashFiles('**/requirements.txt') }}-\
${{ hashFiles('**/.pre-commit-config.yaml') }}
key: >-
${{ env.BASE_CACHE_KEY }}${{
hashFiles('**/requirements-test.txt') }}-${{
hashFiles('**/requirements.txt') }}-${{
hashFiles('**/.pre-commit-config.yaml') }}
# Note that the .terraform directory IS NOT included in the
# cache because if we were caching, then we would need to use
# the `-upgrade=true` option. This option blindly pulls down the
Expand Down Expand Up @@ -169,10 +173,13 @@ jobs:
PACKAGE_VERSION: ${{ steps.setup-env.outputs.staticcheck-version }}
run: go install ${PACKAGE_URL}@${PACKAGE_VERSION}
# TODO: https://github.com/cisagov/skeleton-generic/issues/165
# We are temporarily using @mcdonnnj's forked branch of terraform-docs
# until his PR: https://github.com/terraform-docs/terraform-docs/pull/745
# is approved. This temporary fix will allow for ATX header support when
# terraform-docs is run during linting.
# We are temporarily using a branch of @mcdonnnj's fork of terraform-docs that
# groups changes from his PRs until they are approved and merged:
# https://github.com/terraform-docs/terraform-docs/pull/745
# https://github.com/terraform-docs/terraform-docs/pull/901
# This temporary fix will allow for ATX header support when terraform-docs is run
# during linting and output delimiter rows with cell spacing that passes
# Markdownlint's MD060/table-column-style rule.
- name: Clone ATX headers branch from terraform-docs fork
run: |
git clone \
Expand All @@ -187,7 +194,7 @@ jobs:
-o $(go env GOPATH)/bin/terraform-docs
- name: Install dependencies
run: |
python -m pip install --upgrade pip setuptools wheel
python -m pip install --upgrade pip setuptools
pip install --upgrade --requirement requirements-test.txt
- name: Set up pre-commit hook environments
run: pre-commit install-hooks
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ on:
merge_group:
types:
- checks_requested
# We use the default activity types for the pull_request event as specified here:
# https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request
pull_request:
# The branches here must be a subset of the ones in the push key
branches:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on: # yamllint disable-line rule:truthy
merge_group:
types:
- checks_requested
# We use the default activity types for the pull_request event as specified here:
# https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request
pull_request:

# Set a default shell for any run steps. The `-Eueo pipefail` sets errtrace,
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/label-prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
name: Label pull requests

on: # yamllint disable-line rule:truthy
# We use the default activity types for the pull_request event as specified here:
# https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request
pull_request:
types:
- edited
- opened
- synchronize

# Set a default shell for any run steps. The `-Eueo pipefail` sets errtrace,
# nounset, errexit, and pipefail. The `-x` will print all commands as they are
Expand Down
26 changes: 13 additions & 13 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,32 +45,32 @@ repos:

# Text file hooks
- repo: https://github.com/igorshubovych/markdownlint-cli
rev: v0.45.0
rev: v0.47.0
hooks:
- id: markdownlint
args:
- --config=.mdl_config.yaml
- repo: https://github.com/rbubley/mirrors-prettier
rev: v3.6.2
rev: v3.8.1
hooks:
- id: prettier
- repo: https://github.com/adrienverge/yamllint
rev: v1.37.1
rev: v1.38.0
hooks:
- id: yamllint
args:
- --strict

# GitHub Actions hooks
- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.35.0
rev: 0.36.2
hooks:
- id: check-github-actions
- id: check-github-workflows

# pre-commit hooks
- repo: https://github.com/pre-commit/pre-commit
rev: v4.4.0
rev: v4.5.1
hooks:
- id: validate_manifest

Expand Down Expand Up @@ -129,13 +129,13 @@ repos:

# Python hooks
- repo: https://github.com/PyCQA/bandit
rev: 1.9.1
rev: 1.9.3
hooks:
- id: bandit
args:
- --config=.bandit.yml
- repo: https://github.com/psf/black-pre-commit-mirror
rev: 25.11.0
rev: 26.1.0
hooks:
- id: black
- repo: https://github.com/PyCQA/flake8
Expand All @@ -145,15 +145,15 @@ repos:
additional_dependencies:
- flake8-docstrings==1.7.0
- repo: https://github.com/PyCQA/isort
rev: 7.0.0
rev: 8.0.0
hooks:
- id: isort
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.18.2
rev: v1.19.1
hooks:
- id: mypy
- repo: https://github.com/pypa/pip-audit
rev: v2.9.0
rev: v2.10.0
hooks:
- id: pip-audit
args:
Expand All @@ -165,7 +165,7 @@ repos:
- --requirement
- requirements.txt
- repo: https://github.com/asottile/pyupgrade
rev: v3.21.1
rev: v3.21.2
hooks:
- id: pyupgrade
args:
Expand All @@ -177,7 +177,7 @@ repos:

# Ansible hooks
- repo: https://github.com/ansible/ansible-lint
rev: v25.11.1
rev: v26.1.1
hooks:
- id: ansible-lint
additional_dependencies:
Expand All @@ -203,7 +203,7 @@ repos:

# Terraform hooks
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.103.0
rev: v1.105.0
hooks:
- id: terraform_fmt
- id: terraform_validate
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,14 @@ This meta-role requires a permission policy similar to the following:
## Requirements ##

| Name | Version |
|------|---------|
| ---- | ------- |
| terraform | >= 1.1 |
| aws | >= 4.9 |

## Providers ##

| Name | Version |
|------|---------|
| ---- | ------- |
| aws | >= 4.9 |

## Modules ##
Expand All @@ -93,7 +93,7 @@ No modules.
## Resources ##

| Name | Type |
|------|------|
| ---- | ---- |
| [aws_iam_policy.ssm_policy](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_policy) | resource |
| [aws_iam_role.ssm_role](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role) | resource |
| [aws_iam_role_policy_attachment.ssm_policy_attachment](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
Expand All @@ -104,7 +104,7 @@ No modules.
## Inputs ##

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| ---- | ----------- | ---- | ------- | :------: |
| account\_ids | AWS account IDs that are allowed to assume the role. | `list(string)` | `[]` | no |
| entity\_name | The name of the entity that the role is being created for (e.g. "test-user" or "host.example.com"). | `string` | n/a | yes |
| iam\_usernames | The list of IAM usernames allowed to assume the role. If not provided, defaults to allowing any user in the specified account(s). Note that including "root" in this list will override any other usernames in the list. | `list(string)` | ```[ "root" ]``` | no |
Expand All @@ -116,7 +116,7 @@ No modules.
## Outputs ##

| Name | Description |
|------|-------------|
| ---- | ----------- |
| policy | The IAM policy that can read the specified SSM Parameter Store parameters. |
| role | The IAM role that can read the specified SSM Parameter Store parameters. |
<!-- END_TF_DOCS -->
Expand Down
32 changes: 16 additions & 16 deletions examples/basic_usage/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions examples/basic_usage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Note that this example may create resources which cost money. Run
## Requirements ##

| Name | Version |
|------|---------|
| ---- | ------- |
| terraform | ~> 1.1 |
| aws | ~> 6.7 |

Expand All @@ -23,7 +23,7 @@ No providers.
## Modules ##

| Name | Source | Version |
|------|--------|---------|
| ---- | ------ | ------- |
| ssm\_role | ../../ | n/a |

## Resources ##
Expand All @@ -37,7 +37,7 @@ No inputs.
## Outputs ##

| Name | Description |
|------|-------------|
| ---- | ----------- |
| policy | The IAM policy that can read the specified SSM Parameter Store parameters for site.example.com. |
| role | The IAM role that can read the specified SSM Parameter Store parameters for site.example.com. |
<!-- END_TF_DOCS -->
3 changes: 1 addition & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
setuptools
wheel
setuptools>=70.1
2 changes: 1 addition & 1 deletion setup-env
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ fi
pyenv local "${env_name}"

# Upgrade pip and friends
python3 -m pip install --upgrade pip setuptools wheel
python3 -m pip install --upgrade pip setuptools

# Find a requirements file (if possible) and install
for req_file in "requirements-dev.txt" "requirements-test.txt" "requirements.txt"; do
Expand Down
Loading