-
Notifications
You must be signed in to change notification settings - Fork 21
Unit test for NSMNSE-37: removeClientInterface() function #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @ziyuguo716 add the context to |
Hi @CosminNechifor, not sure if this addresses your comment: @shanchunyang0919 created a go-test circleci job in this PR. So, we are waiting for his circleci job to get merged into the workflow for both of our unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wasn't this merged is there a reason for keeping it open?
This PR is a subtask of NSMNSE-18. @shanchunyang0919 's #38 is the other part of the unit testing for |
Sorry for leaving this dangling @ziyuguo716. What's the consensus on this? If it's not already superseded by other merges please create this PR against the wwwin-github.cisco.com repo and we can merge it in with a quicker final approval. |
Moved to internal repo: https://wwwin-github.cisco.com/cisco-app-networking/nsm-nse/pull/8 |
This PR is a fix from #39 (Wrong branch used)