Fix thread cleanup and memory leaks during partial initialization#3959
Open
sprangerik wants to merge 1 commit into
Open
Fix thread cleanup and memory leaks during partial initialization#3959sprangerik wants to merge 1 commit into
sprangerik wants to merge 1 commit into
Conversation
If CWelsThreadPool::Init() fails halfway through creating worker threads, StopAllRunning() returns an error code because the number of idle threads does not match m_iMaxThreadNum. Previously, Uninit() would return early on this error code without terminating or destroying the worker threads that were already successfully started, leaving them running after the pool was destroyed. This commit updates Uninit() to systematically terminate, join, and clean up all worker threads across both idle and busy lists regardless of StopAllRunning()'s return value. Additionally, if pThread->Start() fails in CreateIdleThread(), the allocated thread object is now freed before returning.
sprangerik
force-pushed
the
thread_pool_tear_down
branch
2 times, most recently
from
f9870ab to
aa0c791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
CWelsThreadPool::Init()fails halfway through creating worker threads,StopAllRunning()returns an error code because the number of idle threads does not matchm_iMaxThreadNum. Previously,Uninit()would return early on this error code without terminating or destroying the worker threads that were already successfully started, leaving them running in the background after the pool was destroyed.This PR updates
Uninit()to systematically terminate, join, and clean up all worker threads across both idle and busy lists regardless ofStopAllRunning()'s return value. Additionally, ifpThread->Start()fails inCreateIdleThread(), the allocated thread object is now freed before returning.