Skip to content

[minor_change] Add hardcoded retry mechanism for json parse errors of response in client #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akinross
Copy link
Contributor

@akinross akinross commented May 2, 2025

No description provided.

Copy link
Contributor

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// Recreate is not consistent accross attempt, where some schemas that failed are parsed correctly next run
// According to CX investigation is related to retransmissions and lost packets
// Workaround for https://github.com/CiscoDevNet/terraform-provider-mso/issues/338
if ok := attempts <= 3; ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add Exponential backoff-> The delay increases exponentially after each attempt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pending discussion from team

@akinross akinross requested a review from shrsr May 6, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants