Refactor Config and fix related bugs
#315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use `ConnectionType::fromstr` for it.
- Currently `OpenOptions` builder is used to deal with file in different scenarios for which `File` implementation already contains api's for that. Hence replaced `OpenOptions` builder code with those api wherever possible.
It aims to: * Refactor several api's used to parse the config contents and removed other unnecessary ones. * Removes config section in `config.toml` of each component. * Solves multiple bugs related to configs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 79.45% 78.28% -1.18%
==========================================
Files 32 32
Lines 4834 4831 -3
==========================================
- Hits 3841 3782 -59
- Misses 993 1049 +56 ☔ View full report in Codecov by Sentry. |
|
Okay to do it later. TODO is good for now. Merging. |
bicodrex
pushed a commit
to bicodrex/coinswap
that referenced
this pull request
Jul 21, 2025
Refactor `Config` and fix related bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces several improvements and refactors which are :
Modify Config for each components:
configof each component.Improved File Handling:
OpenOptionsbuilder with the more straightforwardFileassociated APIs wherever possible in order to simplify file handling code.Removed the
read_connection_network_stringAPI.We can directly use
ConnectionType::from_strinstead.