[WIP] Refactor taker-cli & remove rpc_port from TakerConfig
#320
Conversation
| /// Sets the fee-rate. | ||
| #[clap(name = "fee_rate")] | ||
| fee_rate: u64, | ||
| /// Sets the required on-chain confirmations. | ||
| #[clap(name = "required_confirms")] // TODO: Should we have default as 1? | ||
| required_confirms: u64, |
There was a problem hiding this comment.
I think its better to hardcoded these to some default values, at least in the App. As these can be gamed to make malicious swap requests.
yes a default of required_confirms= 1 is good enough. If it causes reorg problems we will change to 2/3 later. Too high value will make a swap process very slow.
| /// Sets the transaction count. | ||
| #[clap(name = "tx_count", default_value = "3")] | ||
| tx_count: u32, |
There was a problem hiding this comment.
Lets make default to 1. Also this need a good explainer doc. Setting it's value n>1 will create "split-swaps". Which takes 1 or more utxos, and gives n new utxos back.
Setting it to 1 simulates a "merge_swap`, which takes 1 or more utxos, and only give 1 new utxo back.
Splits swaps are more costly than merge swaps. A 3tx swap will be about 3 times more costly than a 1tx swap. This will need to be improved later to reduce coinswap cost. Its unreasonably high right now.
- Document the need of `port` for establishing tor hidden service for `Taker`.
- Make `do-coinswap` a subcommand. - Remove `sync-offerbook` & create `list-offerbook` command
KnowWhoami
force-pushed
the
taker_ports
branch
from
8b7696f to
edd9de7
Compare
|
will be closed by #351 |
2 participants
This pr aims to:
rpc_portfromTakerConfigas Taker is just a application which doesn't require arpc_port.but it requires
portjust for havinghidden serviceswhile running on tor for maintaining privacy so Documented that point.do-coinswaprelated arguments inside the command.sync-offerbookcall as this syncing process is done while performingcoinswapand thus we don't require to have a seperate command for that.list-offerbookcall to see all the offers which taker has in his offerbook.Work left to be done here ( after merging of #305 , #311 ) :
do-coinswapcall -> I am planning to include that bug fix in this pr itselftaker-cliIT to test the remaining commands