Skip to content

Conversation

@stark-3k
Copy link

@stark-3k stark-3k commented Dec 29, 2024

Closes #331

@codecov
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (bcbd223) to head (8faeecd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
- Coverage   73.43%   73.34%   -0.10%     
==========================================
  Files          33       33              
  Lines        4134     4134              
==========================================
- Hits         3036     3032       -4     
- Misses       1098     1102       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack..

Can we add two more section. The data directory structure, and the config file.

At datadir, just give abrief tour of what each file does. And tell them to always backup the wallet files.

At config explain in one lines what each config does.

rest is good to go.

@stark-3k stark-3k force-pushed the rk/taker-tutorial-docs branch from 8faeecd to 3a179ce Compare January 2, 2025 04:33
@stark-3k
Copy link
Author

stark-3k commented Jan 2, 2025

Ack..

Can we add two more section. The data directory structure, and the config file.

At datadir, just give abrief tour of what each file does. And tell them to always backup the wallet files.

At config explain in one lines what each config does.

rest is good to go.

Updated the command, and added a section for Data Directory, Config and Wallets

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@stark-3k stark-3k marked this pull request as ready for review January 2, 2025 07:55
@mojoX911 mojoX911 merged commit 66257e0 into citadel-tech:master Jan 2, 2025
4 of 6 checks passed
bicodrex pushed a commit to bicodrex/coinswap that referenced this pull request Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] Taker-cli + Bitcoin Core Doc

2 participants