Skip to content

Conversation

@stark-3k
Copy link

For the makers in the Taproot protocol, we were still using IP addresses as the key for the swap connection state which was problematic for multiple reasons(simultaneous swaps with two local takers, two connected to the same Tor exit node, etc). This PR updates the code to use swap_id as the key for ConnectionState which solves these issues.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 93.50649% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.26%. Comparing base (776b75d) to head (46e9b72).
⚠️ Report is 64 commits behind head on master.

Files with missing lines Patch % Lines
src/maker/server2.rs 89.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   68.87%   77.26%   +8.38%     
==========================================
  Files          35       49      +14     
  Lines        4932    14462    +9530     
==========================================
+ Hits         3397    11174    +7777     
- Misses       1535     3288    +1753     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. But needs some changes.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@mojoX911 mojoX911 merged commit f2d1ef5 into citadel-tech:master Dec 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants