-
Notifications
You must be signed in to change notification settings - Fork 98
use swap id as identifier for connection #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use swap id as identifier for connection #663
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #663 +/- ##
==========================================
+ Coverage 68.87% 77.26% +8.38%
==========================================
Files 35 49 +14
Lines 4932 14462 +9530
==========================================
+ Hits 3397 11174 +7777
- Misses 1535 3288 +1753 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mojoX911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. But needs some changes.
mojoX911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
For the makers in the Taproot protocol, we were still using IP addresses as the key for the swap connection state which was problematic for multiple reasons(simultaneous swaps with two local takers, two connected to the same Tor exit node, etc). This PR updates the code to use
swap_idas the key for ConnectionState which solves these issues.