Skip to content

Refactor: Streamline the sync API #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mojoX911 merged 2 commits into from
Dec 23, 2025
Merged

Refactor: Streamline the sync API #665

mojoX911 merged 2 commits into from
Dec 23, 2025

Conversation

@Godzilla-oss
Copy link
Collaborator

@Godzilla-oss Godzilla-oss commented Dec 20, 2025

Resolves #662

  • Replace sync and sync_no_fail with sync_and_save
  • Remove some redundant save_to_disk
  • Update tests to use sync_and_save

@Godzilla-oss
Refactor: Streamline the sync API
01c0961 
- Replace sync and sync_no_fail with sync_and_save
- Remove some redundant save_to_disk
- Update tests to use sync_and_save
@codecov
Copy link

codecov bot commented Dec 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.90%. Comparing base (776b75d) to head (0b554ef).
⚠️ Report is 65 commits behind head on master.

Files with missing lines Patch % Lines
src/maker/rpc/server.rs 0.00% 2 Missing ⚠️
src/wallet/ffi.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   68.87%   77.90%   +9.02%     
==========================================
  Files          35       49      +14     
  Lines        4932    14443    +9511     
==========================================
+ Hits         3397    11252    +7855     
- Misses       1535     3191    +1656

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Wukong247
Wukong247 reviewed Dec 21, 2025
View reviewed changes
Copy link
Collaborator

@Wukong247 Wukong247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear the fmt, and its good to go.

Wukong247
Wukong247 approved these changes Dec 21, 2025
View reviewed changes
Copy link
Collaborator

@Wukong247 Wukong247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mojoX911 mojoX911 merged commit c106824 into citadel-tech:master Dec 23, 2025
9 checks passed
@Godzilla-oss Godzilla-oss deleted the sync-api branch December 24, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wukong247 Wukong247 Wukong247 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Streamline the sync api.

3 participants

@Godzilla-oss @Wukong247 @mojoX911