Skip to content

Conversation

@Wukong247
Copy link
Collaborator

@Wukong247 Wukong247 commented Dec 22, 2025

Slice of ife changes to optimize watcher

@Shourya742 Shourya742 force-pushed the 2025-12-21-optimize-watcher branch 4 times, most recently from 97c31d5 to 1900591 Compare December 25, 2025 14:23
@Wukong247 Wukong247 marked this pull request as ready for review December 25, 2025 14:50
@Shourya742 Shourya742 force-pushed the 2025-12-21-optimize-watcher branch 2 times, most recently from 344362a to 786e5e7 Compare December 28, 2025 09:14
@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

❌ Patch coverage is 75.84270% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.49%. Comparing base (776b75d) to head (37d55df).
⚠️ Report is 66 commits behind head on master.

Files with missing lines Patch % Lines
src/taker/offers.rs 81.10% 72 Missing ⚠️
src/taker/api.rs 23.68% 58 Missing ⚠️
src/bin/taker.rs 4.00% 24 Missing ⚠️
src/maker/server2.rs 65.51% 20 Missing ⚠️
src/maker/server.rs 81.03% 11 Missing ⚠️
src/watch_tower/rpc_backend.rs 90.98% 11 Missing ⚠️
src/taker/api2.rs 72.22% 10 Missing ⚠️
src/watch_tower/utils.rs 91.66% 5 Missing ⚠️
src/wallet/fidelity.rs 81.25% 3 Missing ⚠️
src/watch_tower/watcher.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   68.87%   77.49%   +8.62%     
==========================================
  Files          35       49      +14     
  Lines        4932    14835    +9903     
==========================================
+ Hits         3397    11497    +8100     
- Misses       1535     3338    +1803     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Shourya742 Shourya742 force-pushed the 2025-12-21-optimize-watcher branch 8 times, most recently from 9cd35ef to 45321d7 Compare December 29, 2025 13:40
@mojoX911
Copy link

mojoX911 commented Dec 29, 2025

Insane lift @Wukong247 . Made a basic pass. This is the most awesome market logic we have till date. Great work. Will do a thorough review and testing soon.

It would be good if you could mark all the possible TODOs and Improvements in the code site. I am sure there's a lot. Maybe some more crazy optimization ideas that we can add later. We will later turn them into issues. It would be very helpful if they were marked at the code site itself for now.

@Shourya742 Shourya742 force-pushed the 2025-12-21-optimize-watcher branch 2 times, most recently from 994919d to 3f6f336 Compare December 30, 2025 14:05
@Shourya742 Shourya742 force-pushed the 2025-12-21-optimize-watcher branch from 3f6f336 to 37d55df Compare December 30, 2025 14:34
Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@mojoX911 mojoX911 merged commit 97492f8 into citadel-tech:master Dec 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants