-
Notifications
You must be signed in to change notification settings - Fork 98
Optimize watcher #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize watcher #666
Conversation
97c31d5 to
1900591
Compare
344362a to
786e5e7
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 68.87% 77.49% +8.62%
==========================================
Files 35 49 +14
Lines 4932 14835 +9903
==========================================
+ Hits 3397 11497 +8100
- Misses 1535 3338 +1803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9cd35ef to
45321d7
Compare
|
Insane lift @Wukong247 . Made a basic pass. This is the most awesome market logic we have till date. Great work. Will do a thorough review and testing soon. It would be good if you could mark all the possible TODOs and Improvements in the code site. I am sure there's a lot. Maybe some more crazy optimization ideas that we can add later. We will later turn them into issues. It would be very helpful if they were marked at the code site itself for now. |
994919d to
3f6f336
Compare
3f6f336 to
37d55df
Compare
mojoX911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
Slice of ife changes to optimize watcher