Skip to content

Conversation

@stark-3k
Copy link

@stark-3k stark-3k commented Dec 29, 2025

This PR:

  • adds the ability for the wallet to generate P2TR key-path spending addresses using the taproot descriptors
  • introduces AddressType enum to specify the type of address generation for various usecases
  • defaults to P2WPKH for v1 protocol and uses P2TR for v2 protocol
  • fixes a coin selection bug where target value was incorrectly calculated after group UTXO selection

@stark-3k stark-3k force-pushed the add-taproot-wallet-descriptors branch from 498dc03 to 54ebebd Compare December 31, 2025 08:08
fix doc clippy and cli defaults to P2WPKH address

fix coin selection bug and use taproot change addresses
@stark-3k stark-3k force-pushed the add-taproot-wallet-descriptors branch from 54ebebd to 3269506 Compare December 31, 2025 08:39
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 86.58009% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.58%. Comparing base (776b75d) to head (51cb6af).
⚠️ Report is 68 commits behind head on master.

Files with missing lines Patch % Lines
src/wallet/api.rs 92.02% 13 Missing ⚠️
src/maker/rpc/server.rs 0.00% 5 Missing ⚠️
src/maker/server2.rs 55.55% 4 Missing ⚠️
src/wallet/error.rs 0.00% 3 Missing ⚠️
src/wallet/funding.rs 25.00% 3 Missing ⚠️
src/wallet/fidelity.rs 75.00% 2 Missing ⚠️
src/wallet/ffi.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
+ Coverage   68.87%   77.58%   +8.70%     
==========================================
  Files          35       49      +14     
  Lines        4932    14990   +10058     
==========================================
+ Hits         3397    11630    +8233     
- Misses       1535     3360    +1825     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stark-3k stark-3k marked this pull request as ready for review December 31, 2025 10:59
@stark-3k stark-3k requested a review from mojoX911 December 31, 2025 13:31
Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. One questions below.

Also does it makes sense to make all transactions taproot by default now that the wallet can handle both?

@stark-3k stark-3k requested a review from mojoX911 December 31, 2025 14:33
Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@mojoX911 mojoX911 merged commit 1312a0b into citadel-tech:master Dec 31, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants