Skip to content

Conversation

@0xEgao
Copy link
Collaborator

@0xEgao 0xEgao commented Jan 17, 2026

This pr aims to resolve all marked TODO in maker module, and fixes #703 partially

TODO's fixed-:
1-) Encapsulated the maker's watcher initialization into an api named as start_maker_watch_service to avoid code repetition.
2-) Created nostr_coinswap module to transfer bunch of api's from maker's server to a common place.
3-) Refactored the v2-maker logic to create ConnectionState after receiving SwapDetails from Taker, as GetOffer message usually contains empty string in swap-id.
4-) Uncommented a marked todo in maker handlers2 module.

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 72.41379% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.77%. Comparing base (776b75d) to head (2ebc164).
⚠️ Report is 87 commits behind head on master.

Files with missing lines Patch % Lines
src/nostr_coinswap.rs 59.32% 24 Missing ⚠️
src/maker/handlers2.rs 57.89% 8 Missing ⚠️
src/maker/server2.rs 73.91% 6 Missing ⚠️
src/taker/api2.rs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #713       +/-   ##
===========================================
+ Coverage   68.87%   80.77%   +11.89%     
===========================================
  Files          35       50       +15     
  Lines        4932    14692     +9760     
===========================================
+ Hits         3397    11867     +8470     
- Misses       1535     2825     +1290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mojoX911
Copy link

@0xEgao is this ready for review?

@0xEgao
Copy link
Collaborator Author

0xEgao commented Jan 21, 2026

@0xEgao is this ready for review?
Not right now, will be ready for review tomorrow.

@0xEgao 0xEgao force-pushed the maker-todo branch 3 times, most recently from b3eb834 to cf74292 Compare January 21, 2026 20:52
@0xEgao 0xEgao marked this pull request as ready for review January 22, 2026 05:45
@0xEgao 0xEgao requested review from mojoX911 and stark-3k January 22, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solve all TODOs

2 participants