Skip to content

Conversation

@0xEgao
Copy link
Collaborator

@0xEgao 0xEgao commented Jan 22, 2026

This pr aims to resolve all marked TODO in protocol module, and fixes #703 partially,

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.74%. Comparing base (776b75d) to head (34aaacb).
⚠️ Report is 88 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #725       +/-   ##
===========================================
+ Coverage   68.87%   80.74%   +11.87%     
===========================================
  Files          35       49       +14     
  Lines        4932    14706     +9774     
===========================================
+ Hits         3397    11875     +8478     
- Misses       1535     2831     +1296     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@stark-3k stark-3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not need this now because it doesn't really change anything and we will also be upgrading our rust bitcoin version which will resolve the need for a compatibility layer.

@mojoX911
Copy link

Yeah this is probably redundant. But as its done already will merge it in to reduce review scope.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@mojoX911 mojoX911 merged commit fbdd13d into citadel-tech:master Jan 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solve all TODOs

3 participants