-
Notifications
You must be signed in to change notification settings - Fork 98
CI test improvements #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CI test improvements #726
Conversation
Godzilla-oss
commented
Jan 22, 2026
- cache test builds
- retry once if a test fails
- replace fail-fast with a maximum of 5 test failures
- test timeout after 1h 30m
- parallel test execution
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
===========================================
+ Coverage 68.87% 80.78% +11.91%
===========================================
Files 35 49 +14
Lines 4932 14419 +9487
===========================================
+ Hits 3397 11649 +8252
- Misses 1535 2770 +1235 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.github/workflows/test.yaml
Outdated
| cargo llvm-cov nextest --lib --bins --tests --fail-fast --features integration-test --no-capture | ||
| cargo llvm-cov report --cobertura --output-path ./coverage/reports/cobertura.xml | ||
| cargo llvm-cov nextest --lib --bins --tests --retries 1 --max-fail 5:immediate --partition hash:${{ matrix.partition }}/2 --features integration-test --no-capture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this run all the tests paralley? or create 2 parallel run streams based on the partitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create 2 parallel runners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this line hash:${{ matrix.partition }}/2 the partition number will always be 1? Seems like an integer ops, but I might be reading it wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create 5 partitions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this line
hash:${{ matrix.partition }}/2the partition number will always be 1? Seems like an integer ops, but I might be reading it wrong.
This is not performing a mathematical operation; the argument for --partition should be passed using this syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create 5 partitions?
yes we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create 5 partitions?
yes we can.
then let's do it
7f294fd to
dc215f0
Compare
- cache test builds - retry once if a test fails - replace fail-fast with a maximum of 3 test failures - test timeout after 1h 30m - parallel test execution