Skip to content

Update society-of-biblical-literature-fullnote-bibliography.csl #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dstark
Copy link
Contributor

@dstark dstark commented Apr 14, 2025

Adjust originally-published grouping in the bibliography so that items without original-date (i.e., co-publications where one publisher is just as original as another) get a semicolon rather than a period before the second set of publication facts.

Adjust originally-published grouping in the bibliography so that items without original-date (i.e., co-publications where one publisher is just as original as another) get a semicolon rather than a period before the second set of publication facts.
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

society-of-biblical-literature-fullnote-bibliography.csl (modified style; unchanged output for sample items)
Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy, , ; (Oxford and New York: Oxford University Press, 2007); ; ; ; ; “CSL Search by Example,” Citation Style Editor, , ; , 2012; ; ; ; , http://editor.citationstyles.org/searchByExample/.
Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, ed. Peter A. Hall and David Soskice, , ; (New York: Oxford University Press, 2001); ; ; , 184–213; ; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” Sci. Data, , ; 6.1 (2019); ; ; : 28; , https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.

“CSL Search by Example.” Citation Style Editor, 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, Robin Berjon, Sebastian Karcher, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Sci. Data 6.1 (2019): 28. https://doi.org/10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” Pages 184–213 in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage. Edited by Peter A. Hall and David Soskice. New York: Oxford University Press, 2001.

@bwiernik
Copy link
Member

CSL currently assumes that multiple publishers are stored together in one publisher field.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Apr 15, 2025
@dstark
Copy link
Contributor Author

dstark commented Apr 16, 2025

Thanks so much, @bwiernik. Is there then a better way of entering information so that Zotero can provide citations and bibliography entries in this format?

The best I've been able to come up with otherwise is something like this.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Apr 16, 2025
@bwiernik
Copy link
Member

@adam3smith Thoughts here? Repurposing the original-publisher variable here feels very hacky and I don't want to necessarily encourage the level of style-specific data entry.

Publisher is changed to a name variable in the current draft of the CSL 1.1 spec, but unclear when we might get that finalized and implemented.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Apr 16, 2025
@bwiernik
Copy link
Member

@dstark Zotero's citation processor has a capability of splitting the publisher and place fields on a semicolon and then joining them together with delimiters if arguments are set in the style.

These style attributes aren't in the official CSL spec, so we wouldn't accept a style using them here, but you could host a variant elsewhere. I have not tested if this works.

The subgroup-delimiter attribute is a field-parsing hack coded into the citeproc-js processor, enabled when the processor is run in CSL-m mode. In a group containing only cs:text elements rendering the publisher and publisher-place variables, the processor will split the content of both fields on a semicolon. If the length of the resulting list objects is equal, each publisher/publisher-place pair will be joined with the delimiter string set on the enclosing cs:group element. The composed pairs are then joined using the subgroup-delimiter value.

https://citeproc-js.readthedocs.io/en/latest/csl-m/

@dstark
Copy link
Contributor Author

dstark commented Apr 17, 2025

@dstark Zotero's citation processor has a capability of splitting the publisher and place fields on a semicolon and then joining them together with delimiters if arguments are set in the style.

These style attributes aren't in the official CSL spec, so we wouldn't accept a style using them here, but you could host a variant elsewhere. I have not tested if this works.

The subgroup-delimiter attribute is a field-parsing hack coded into the citeproc-js processor, enabled when the processor is run in CSL-m mode. In a group containing only cs:text elements rendering the publisher and publisher-place variables, the processor will split the content of both fields on a semicolon. If the length of the resulting list objects is equal, each publisher/publisher-place pair will be joined with the delimiter string set on the enclosing cs:group element. The composed pairs are then joined using the subgroup-delimiter value.

https://citeproc-js.readthedocs.io/en/latest/csl-m/

Thanks, @bwiernik. This fact possibly explains why I've sometimes seen different output from Pandoc's citeproc than with citeproc-js, though not on this issue. I'll bear this in mind as I watch for cases that I come across like this moving forward as it should help me sort out why, on certain rare occasions, I'm not seeing from citeproc what I anticipated based on citeproc-js.

Also, if I might add a further thought about your comment to @adam3smith that "I don't want to necessarily encourage … style-specific data entry," I would totally agree with this and am hopeful this proposal might do just that.

Regarding how "repurposing the original-publisher variable here feels very hacky," I was hoping this use of original-publisher might be appropriate since the 1.0.2 specification defines original-publisher as

Original publisher, for items that have been republished by a different publisher

I fully agree that the most prototypical example of this situation is for cases where one publisher releases a work and then, after some time, another publisher releases the same work.

But strictly speaking, the CSL specification doesn't look like it requires that a certain interval of time must pass between the release by the "original publisher" and the release "by a different publisher." And with co-published works, the work of each publisher is reciprocally and simultaneously "republished by a different publisher."

There is some level of arbitrariness here—Why identify one publisher as publisher and the other as original-publisher? But as far as I can tell, neither SBL Press's style authorities, nor those that it borrows from Chicago seem to offer any guidance on this question either. So, on that front, this minor bit of arbitrariness is part of the style.

I'm not sure if any of this might be useful in considering whether to accept this pull request, but this is just a bit more fully how I've been thinking about this point, in case that context is at all helpful.

If I can provide anything else, please feel free to ask. Meanwhile, thanks so much for all your continued, careful work stewarding this repository.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Apr 17, 2025
@denismaier
Copy link
Member

Thanks, @bwiernik. This fact possibly explains why I've sometimes seen different output from Pandoc's citeproc than with citeproc-js, though not on this issue. I'll bear this in mind as I watch for cases that I come across like this moving forward as it should help me sort out why, on certain rare occasions, I'm not seeing from citeproc what I anticipated based on citeproc-js.

No, that's probably not that. citeproc-js behaves differently than pandoc's citeproc with the same styles, but this is something different. You'll need to enable this explicitly in the style with version="1.1mlz1" to make the processor switch to csl-m mode.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Apr 18, 2025
@bwiernik
Copy link
Member

Thanks @denismaier wasn't sure what the next enabling step was

@dstark
Copy link
Contributor Author

dstark commented Apr 23, 2025

No, that's probably not that. citeproc-js behaves differently than pandoc's citeproc with the same styles, but this is something different.

Thanks @denismaier. Are you aware of any documentation that outlines the differences between the two?

(Sorry this is a slight a rabbit trail here. But I'm not seeing a way to do a DM here on GitHub.)

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Apr 23, 2025
@dstark
Copy link
Contributor Author

dstark commented Apr 23, 2025

Thanks for the feedback, all. Given the current CSL specification, it looks like the options are to

  1. leave the style as-is and unable to produce exactly what SBL style requires for this scenario,
  2. adapt the style to use the original-publisher and original-publisher-place fields since co-publishers are both original, or
  3. use a non-CSL feature that works (only?) in citeproc-js.

If neither option 2 nor option 3 can be incorporated into the main style here,

  • Would there be a better way to accommodate what SBL style requires for co-published works that could be merged into the main style?
  • If I were to host elsewhere a forked style that handles this use case, could you help me understand whether there an upside of option 3 that makes up for its reliance on something that isn't in the current CSL specification and (it sounds like) isn't currently being contemplated for the one to come?

As always, thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants