-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Create re-visit.csl #7934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create re-visit.csl #7934
Conversation
English and German full note style for Journal Re:visit - Humanities and Medicine in Dialogue (edit of Zeitschrift für Theologie und Philosophie).
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: re-visit.csl (new)Bob Hancké et al. (eds.): ; Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy; . Oxford ; 2007; , DOI: 10.1093/acprof:oso/9780199206483.001.0001; CSL search by example; (2012); , in: Citation style editor; , http://editor.citationstyles.org/searchByExample/, 12/15/2012. |
repaired some problems with special document types
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: re-visit.csl (new)Bob Hancké et al. (eds.): ; Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy; . Oxford ; 2007; . DOI: 10.1093/acprof:oso/9780199206483.001.0001; CSL search by example; . In: Citation style editor; (2012); . http://editor.citationstyles.org/searchByExample/ (12/15/2012). |
POBrien333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission of such a good quality. Doesn't happen to often here ;)
Couple of comments and we can merge.
| <text term="ibid"/> | ||
| </else-if> | ||
| <else-if position="subsequent"> | ||
| <text macro="author-short" suffix=": "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this suffix can lead to issues. Can you put these three elements into groups and set delimitiers as needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I see you rely on a lot of suffixes. Try to replace them with groups or prefixes as much as you can.
| </else-if> | ||
| <else> | ||
| <text macro="author-long" suffix=": "/> | ||
| <text macro="title" font-style="normal"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove th normal if not needed
| <text macro="point-locators-subsequent"/> | ||
| </else-if> | ||
| <else> | ||
| <text macro="author-long" suffix=": "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here with the suffix. put into groups
| <macro name="access-note"> | ||
| <choose> | ||
| <if type="article-journal book chapter entry-encyclopedia entry-dictionary" match="any"> | ||
| <text variable="DOI" prefix=". DOI: "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if the ". " was set where you call the macro. Same for the URL in line 168.
| <term name="editortranslator" form="verb-short">hg. und übers. von</term> | ||
| <term name="et-al">u. a.</term> | ||
| <term name="reviewed-author">Rez.</term> | ||
| <term name="folio" form="short">fol.</term> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking. You want this with a small "f"?
| @@ -0,0 +1,452 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="note"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add <!-- Polyglot; journal publishes in English, and German. --> after line 1.

CSL Styles Pull Request Template
You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.
Description
English and German full note style for Journal Re:visit - Humanities and Medicine in Dialogue (edit of Zeitschrift für Theologie und Philosophie).
Checklist
<info>block at the beginning of the file withrel="template".rel="documentation".<author>of the style or<contributor>for a style update.<text variable="page" prefix="pp. "/>).<text value="...if not absolutely necessary.