Skip to content

Conversation

@hoepefuel
Copy link

@hoepefuel hoepefuel commented Nov 29, 2025

CSL Styles Pull Request Template

You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.

Description

English and German full note style for Journal Re:visit - Humanities and Medicine in Dialogue (edit of Zeitschrift für Theologie und Philosophie).

Checklist

  • Check that you've added a link to the style you used as a template in the <info> block at the beginning of the file with rel="template".
  • Check that you've added a link to the style guidelines with rel="documentation".
  • Check that you've added yourself as the <author> of the style or <contributor> for a style update.
  • Check that you've used the correct terms or labels instead of hardcoding into affixes (e.g., <text variable="page" prefix="pp. "/>).
  • Check that you've not used <text value="... if not absolutely necessary.
  • Check that you've not changed line 1 of the style.

English and German full note style for Journal Re:visit - Humanities and Medicine in Dialogue (edit of Zeitschrift für Theologie und Philosophie).
@github-actions
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

re-visit.csl (new)
Bob Hancké et al. (eds.): ; Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy; . Oxford ; 2007; , DOI: 10.1093/acprof:oso/9780199206483.001.0001; CSL search by example; (2012); , in: Citation style editor; , http://editor.citationstyles.org/searchByExample/, 12/15/2012.
Isabela Mares: ; Firms and the welfare state: When, why, and how does social policy matter to employers?; . In: ; Peter A. Hall, David Soskice (eds.): ; Varieties of capitalism: The institutional foundations of comparative advantage; . Oxford ; 2001; , 184–212; , DOI: 10.1093/0199247757.003.0005; Martin Fenner et al.: ; A data citation roadmap for scholarly data repositories; . In: ; Scientific Data; 6; (2019); , 28; , DOI: 10.1038/s41597-019-0031-8.

CSL search by example (2012). In: Citation style editor, http://editor.citationstyles.org/searchByExample/, 12/15/2012.
Fenner, Martin et al., A data citation roadmap for scholarly data repositories. In: Scientific Data 6 (2019), 28, DOI: 10.1038/s41597-019-0031-8.
Hancké, Bob, Rhodes, Martin, Thatcher, Mark (eds.), Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy. Oxford 2007, DOI: 10.1093/acprof:oso/9780199206483.001.0001.
Mares, Isabela, Firms and the welfare state: When, why, and how does social policy matter to employers? In: Peter A. Hall, David Soskice (eds.): Varieties of capitalism: The institutional foundations of comparative advantage. Oxford 2001, 184–212, DOI: 10.1093/0199247757.003.0005.

repaired some problems with special document types
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

re-visit.csl (new)
Bob Hancké et al. (eds.): ; Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy; . Oxford ; 2007; . DOI: 10.1093/acprof:oso/9780199206483.001.0001; CSL search by example; . In: Citation style editor; (2012); . http://editor.citationstyles.org/searchByExample/ (12/15/2012).
Isabela Mares: ; Firms and the welfare state: When, why, and how does social policy matter to employers?; . In: ; Peter A. Hall, David Soskice (eds.): ; Varieties of capitalism: The institutional foundations of comparative advantage; . Oxford ; 2001; , 184–212; . DOI: 10.1093/0199247757.003.0005; Martin Fenner et al.: ; A data citation roadmap for scholarly data repositories; . In: ; Scientific Data; 6; (2019); , 28; . DOI: 10.1038/s41597-019-0031-8.

CSL search by example. In: Citation style editor (2012). http://editor.citationstyles.org/searchByExample/ (12/15/2012).
Fenner, Martin et al.: A data citation roadmap for scholarly data repositories. In: Scientific Data 6 (2019), 28. DOI: 10.1038/s41597-019-0031-8.
Hancké, Bob, Rhodes, Martin, Thatcher, Mark (eds.): Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy. Oxford 2007. DOI: 10.1093/acprof:oso/9780199206483.001.0001.
Mares, Isabela: Firms and the welfare state: When, why, and how does social policy matter to employers? In: Peter A. Hall, David Soskice (eds.): Varieties of capitalism: The institutional foundations of comparative advantage. Oxford 2001, 184–212. DOI: 10.1093/0199247757.003.0005.

Copy link
Contributor

@POBrien333 POBrien333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission of such a good quality. Doesn't happen to often here ;)
Couple of comments and we can merge.

<text term="ibid"/>
</else-if>
<else-if position="subsequent">
<text macro="author-short" suffix=": "/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this suffix can lead to issues. Can you put these three elements into groups and set delimitiers as needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I see you rely on a lot of suffixes. Try to replace them with groups or prefixes as much as you can.

</else-if>
<else>
<text macro="author-long" suffix=": "/>
<text macro="title" font-style="normal"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove th normal if not needed

<text macro="point-locators-subsequent"/>
</else-if>
<else>
<text macro="author-long" suffix=": "/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here with the suffix. put into groups

<macro name="access-note">
<choose>
<if type="article-journal book chapter entry-encyclopedia entry-dictionary" match="any">
<text variable="DOI" prefix=". DOI: "/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if the ". " was set where you call the macro. Same for the URL in line 168.

<term name="editortranslator" form="verb-short">hg. und übers. von</term>
<term name="et-al">u. a.</term>
<term name="reviewed-author">Rez.</term>
<term name="folio" form="short">fol.</term>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking. You want this with a small "f"?

@@ -0,0 +1,452 @@
<?xml version="1.0" encoding="utf-8"?>
<style xmlns="http://purl.org/net/xbiblio/csl" version="1.0" class="note">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add <!-- Polyglot; journal publishes in English, and German. --> after line 1.

@POBrien333 POBrien333 added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants