Skip to content

Conversation

@emabucc90
Copy link

@emabucc90 emabucc90 commented Dec 1, 2025

CSL Styles Pull Request Template

You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.

Description

This CSL style is based on APA 7th edition with mandatory DOI and italicized journal titles.

Checklist

  • Check that you've added a link to the style you used as a template in the <info> block at the beginning of the file with rel="template".
  • Check that you've added a link to the style guidelines with rel="documentation".
  • Check that you've added yourself as the <author> of the style or <contributor> for a style update.
  • Check that you've used the correct terms or labels instead of hardcoding into affixes (e.g., <text variable="page" prefix="pp. "/>).
  • Check that you've not used <text value="... if not absolutely necessary.
  • Check that you've not changed line 1 of the style.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

😟 There are some issues with your submission.

3 tests failed

ijnh-apa7: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Element category failed to validate attributes"], [0, "ERROR: Extra element categ... style failed to validate content"], [7, "7:0: ERROR: Element style failed to validate attributes"]].empty?` to be truthy, got false

ijnh-apa7: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/ijnh-apa7"
     got: "https://www.i-editore.it/styles/ijnh-apa7"

(compared using ==)

ijnh-apa7: must have the correct Creative Commons BY-SA license text

expected: "This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License"
     got: "\n      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.\n    "

(compared using ==)

Diff:
@@ -1,3 +1,5 @@
-This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License
+
+      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.
+

Please check the test report for details.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

😟 There are some issues with your submission.

3 tests failed

ijnh-apa7: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[20, "20:0: ERROR: Element category failed to validate attributes"], [0, "ERROR: Extra element categ... style failed to validate content"], [7, "7:0: ERROR: Element style failed to validate attributes"]].empty?` to be truthy, got false

ijnh-apa7: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/ijnh-apa7"
     got: "https://www.i-editore.it/styles/ijnh-apa7"

(compared using ==)

ijnh-apa7: must have the correct Creative Commons BY-SA license text

expected: "This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License"
     got: "\n      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.\n    "

(compared using ==)

Diff:
@@ -1,3 +1,5 @@
-This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License
+
+      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.
+

Please check the test report for details.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

😟 There are some issues with your submission.

3 tests failed

ijnh-apa7: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "Multiple errors encountered:\n158:49: FATAL: attributes construct error\n158:49: FATAL: Couldn't find end of Start Tag text line 158"]].empty?` to be truthy, got false

ijnh-apa7: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/ijnh-apa7"
     got: "http://www.zotero.org/styles/interdisciplinary-journal-of-nursing-and-health"

(compared using ==)

ijnh-apa7: must have the correct Creative Commons BY-SA license text

expected: "This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License"
     got: "\n      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.\n    "

(compared using ==)

Diff:
@@ -1,3 +1,5 @@
-This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License
+
+      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.
+

Please check the test report for details.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

😟 There are some issues with your submission.

2 tests failed

interdisciplinary-journal-of-nursing-and-health: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[0, "Multiple errors encountered:\n158:49: FATAL: attributes construct error\n158:49: FATAL: Couldn't find end of Start Tag text line 158"]].empty?` to be truthy, got false

interdisciplinary-journal-of-nursing-and-health: must have the correct Creative Commons BY-SA license text

expected: "This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License"
     got: "\n      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.\n    "

(compared using ==)

Diff:
@@ -1,3 +1,5 @@
-This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License
+
+      This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.
+

Please check the test report for details.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

interdisciplinary-journal-of-nursing-and-health.csl (new)
(CSL search by example, 2012; Hancké, Rhodes, & Thatcher, 2007)
(Fenner, Crosas, Grethe, Kennedy, Hermjakob, Rocca-Serra, Durand, Berjon, Karcher, Martone, & Clark, 2019; Mares, 2001)

CSL search by example. (2012). . http://editor.citationstyles.org/searchByExample/.
M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, & T. Clark. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. . https://doi.org/10.1038/s41597-019-0031-8.
B. Hancké, M. Rhodes, & M. Thatcher (eds). (2007). Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy. Oxford University Press, Oxford. . https://doi.org/10.1093/acprof:oso/9780199206483.001.0001.
I. Mares. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In , P. A. Hall, & D. Soskice (eds), Varieties of capitalism: The institutional foundations of comparative advantage, (pp. 184–212). Oxford University Press, Oxford. . https://doi.org/10.1093/0199247757.003.0005.

@POBrien333
Copy link
Contributor

@emabucc90
Thanks for your submission. As you see it took quite a bit of work to get into shape to validate and be in an acceptable state.
However, I see that you basically just copied an author-date style, but all the publications are in a numeric superscript style. Can you explain this discrepancy?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 3, 2025
@emabucc90
Copy link
Author

emabucc90 commented Dec 3, 2025 via email

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 3, 2025
@POBrien333
Copy link
Contributor

POBrien333 commented Dec 3, 2025

all these things are possible, but as I said the journal you submitted a style for, I assume you are part of the editorial team, does NOT use an author-date style. I don't see that in the guidelines nor in recent publications.
Why do you want an author-date style?
It doesn't make sense to host a style on our repository that then doesn't help authors in preparing their manuscript and will then lead to questions.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 3, 2025
@emabucc90
Copy link
Author

emabucc90 commented Dec 3, 2025 via email

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 3, 2025
@POBrien333
Copy link
Contributor

Right. That was not clear at all.

And how come you just didn't take the APA style we have on file?
Or at least take that style and make the minor edits you want? In the end that's our most curated style we have with extremely high quality. The style you're proposing is very rudimentary (and with mistakes that still need fixing).

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 3, 2025
@emabucc90
Copy link
Author

emabucc90 commented Dec 3, 2025 via email

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 3, 2025
@adunning
Copy link
Contributor

adunning commented Dec 3, 2025

@emabucc90 If you're using normal APA style, you can simply create a dependent style (or someone will happily create one for you) that gives the journal its own style in the Zotero repository without needing to maintain an additional set of code for it.

@POBrien333 POBrien333 added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 10, 2025
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

interdisciplinary-journal-of-nursing-and-health.csl (new)
(CSL search by example, 2012; Hancké, Rhodes, & Thatcher, 2007)
(Fenner, Crosas, Grethe, Kennedy, Hermjakob, Rocca-Serra, Durand, Berjon, Karcher, Martone, & Clark, 2019; Mares, 2001)

CSL search by example. (2012). . http://editor.citationstyles.org/searchByExample/.
M. Fenner, M. Crosas, J. S. Grethe, D. Kennedy, H. Hermjakob, P. Rocca-Serra, G. Durand, R. Berjon, S. Karcher, M. Martone, & T. Clark. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. . https://doi.org/10.1038/s41597-019-0031-8.
B. Hancké, M. Rhodes, & M. Thatcher (eds). (2007). Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy. Oxford University Press, Oxford. . https://doi.org/10.1093/acprof:oso/9780199206483.001.0001.
I. Mares. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In , P. A. Hall, & D. Soskice (eds), Varieties of capitalism: The institutional foundations of comparative advantage, (pp. 184–212). Oxford University Press, Oxford. . https://doi.org/10.1093/0199247757.003.0005.

@emabucc90 emabucc90 closed this Dec 18, 2025
@emabucc90 emabucc90 reopened this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants