Skip to content

feat(extra-natives/five): add getters for new track junction #3197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheGamerzs
Copy link
Contributor

@TheGamerzs TheGamerzs commented Feb 26, 2025

Goal of this PR

Add new natives to expand on the track junction natives.
It allows for resources to manage track junctions that they have not created.

How is this PR achieving the goal

Add natives:
GET_TRACK_JUNCTION_FROM_NODES - Returns the junction id from track, nodes, directionn
GET_TRACK_JUNCTION_INFO - Returns the tracks, nodes, direction data
IS_TRACK_JUNCTION_ACTIVE - Returns the state of the track junction

This PR applies to the following area(s)

FiveM, Natives

Successfully tested on

Game builds: 1604, 2060, 2189, 2372, 2545, 2612, 2699, 2802, 2944, 3095, 3258, 3323, 3407

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 26, 2025
@TheGamerzs TheGamerzs force-pushed the natives-track-junction branch from 34ff92a to f27f8c6 Compare February 26, 2025 02:07
@TheGamerzs TheGamerzs force-pushed the natives-track-junction branch from f27f8c6 to e24873b Compare February 27, 2025 00:56
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action labels Feb 27, 2025
@TheGamerzs
Copy link
Contributor Author

Will need to update, depending on #3200

@Legacy-TacticalGamingInteractive

Reminder to see about adding to DOCS as there have been a lot of recent additions regarding trains/tracks etc that may not be reflected in the Docs

@TheGamerzs
Copy link
Contributor Author

recent additions regarding trains/tracks

I am aware of these additions, and that is why this PR is expanding it.

@TheGamerzs TheGamerzs force-pushed the natives-track-junction branch from e24873b to def4e46 Compare May 21, 2025 12:03
@Legacy-TacticalGamingInteractive

recent additions regarding trains/tracks

I am aware of these additions, and that is why this PR is expanding it.

Excellent

@TheGamerzs TheGamerzs force-pushed the natives-track-junction branch from def4e46 to 4657228 Compare May 21, 2025 12:08
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels May 21, 2025
@TheGamerzs
Copy link
Contributor Author

These natives are now updated to use the bitset from commit 65da042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants