Skip to content

Increase map legend blip limit #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

william-des
Copy link
Contributor

@william-des william-des commented Apr 17, 2025

Goal of this PR

Increase the 100-blip limit in the pause menu map legend for game builds below 3258.

How is this PR achieving the goal

Patches the value comparison to raise the hardcoded maximum blip group limit from 100 to 255

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 1604, 2189, 2372, 2802, 3095

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

https://forum.cfx.re/t/change-maximum-amount-of-blips/1059087/9

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Apr 17, 2025
@d22tny
Copy link
Contributor

d22tny commented Apr 17, 2025

The tests i've done in the issue you've linked are done in 3095. What is the 99 limit ?

image

image

Because those are greater that 99.

@william-des
Copy link
Contributor Author

william-des commented Apr 17, 2025

Are you sure you tested this on 3095 without sv_replaceExeToSwitchBuilds set to false?

I can consistently reproduce this issue on builds below 3258 with the following code:

for i = 1, 200 do
    local blip = AddBlipForCoord(0.0, 0.0, 0.0)
    SetBlipSprite(blip, 1)
    SetBlipColour(blip, 1)
    BeginTextCommandSetBlipName("STRING")
    AddTextComponentString("Blip " .. i)
    EndTextCommandSetBlipName(blip)
    Wait(1)
end

I unlinked the issue because it wasn’t clear which builds were being tested, and there also seemed to be a second, unrelated problem related to too many BeginTextCommandSetBlipName calls per tick

@d22tny
Copy link
Contributor

d22tny commented Apr 17, 2025

sv_replaceExeToSwitchBuilds is not specified at all in my server.cfg in the test environment. And it defaults to true, so yeah, this is kinda weird?

@Gogsi
Copy link

Gogsi commented Apr 17, 2025

It should default to true on all artifacts over 12872

@prikolium-cfx prikolium-cfx added the status:deferred Action on this has been deferred to a later time label Apr 17, 2025
@d22tny
Copy link
Contributor

d22tny commented Apr 17, 2025

I might have an older artifact then, if someone else can test this then and it's allright i'm sorry for the confusion:)

@n3xuuu
Copy link
Contributor

n3xuuu commented Apr 17, 2025

Just tested this on game build 3095 with sv_replaceExeToSwitchBuilds enabled.
image
And yes, in fact, it's limited to 99 blips, so this pull request is needed.

@Legacy-TacticalGamingInteractive

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:deferred Action on this has been deferred to a later time triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants