fix(gta-core-five): invalid bounding volume hierarchy #3349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
triage
Nobelium-cfx
approved these changes
Apr 21, 2025
Nobelium-cfx
added
ready-to-merge
github-actions
bot
added
the
triage
tweak(gta-core-five): add missing padding to phOptimizedBvh structure
DaniGP17
force-pushed
the
fix/bounding-volume-hierarchy
branch
from
0097074 to
0f373a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix a crash that occurred in the call to the
CalcClosestLeafDistancefunction that is responsible for traversing the bvh to find the squared distance to the closest leaf node from the given position.The function could crash if the bvh or bvhNode pointer was null.
How is this PR achieving the goal
Adding a check before the original call of the function.
This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: 1604, 3095, 3407
Platforms: Windows, Linux
Checklist
Fixes issues
fixes #3155