tweak(native-decls): update documentation for trains #3353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nobelium-cfx
approved these changes
Apr 21, 2025
Mathu-lmn
reviewed
Apr 21, 2025
github-actions
bot
added
the
triage
| **NOTE**: This native doesn't guarantee the persistence of the entity. | ||
| When used on trains, this native will recursively call onto all attached carriages. | ||
|
|
||
| **NOTE**: When used with `KeepEntity` (2) this native only guarantees that the ***server*** will not delete the entity, client requests to delete the entity will still work perfectly fine. |
There was a problem hiding this comment.
if entity is created serverside, won't sv_protectServerEntities convar prevent the client from deleting the entity?
If yes, this note may cause some misunderstanding.
There was a problem hiding this comment.
if entity is created serverside, won't
sv_protectServerEntitiesconvar prevent the client from deleting the entity?If yes, this note may cause some misunderstanding.
At this moment trains are unable to be created on the server I misread. But yes, the client will be unable to delete it
There was a problem hiding this comment.
GitHub is little funky with the comment creation, but I meant the line 30 exclusively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Cleanup the wording in the native declaration to make it less confusing, and add information about how this works with trains
Is confusing wording, replaced with what is actually defined behavior (that the server will not delete the entity in its normal garbage collection)
This PR applies to the following area(s)
Server
Successfully tested on
N/A
Checklist