feat(core/rdr3): block level loading #3376
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
RedM
Ehbw
force-pushed
the
feat/rdr3-block-level-loading
branch
from
ca9cbfc to
1e76291
Compare
Currently, RedM will run through the entire gameSkeleton::RunInitFunctions (up to INIT_SESSION). This leads to several subsystems in RDR3 (such as CTrain, CNetwork, etc) being initalized before a user connects to a server. This leads to servers not being able to override these components. Rendering rdr3.meta changes pointless. The early initialization of CNetwork also leads to some minor issues with OneSync mainly effecting the future object length extension This patch matches FiveM's behaviour by preventing the game from loading past INIT_CORE until a connection is successfully made to a server where loading resumes. This changeset also introduces support for servers to properly override the games RDR3.meta while cleaning up citizen-level-loader-rdr3 to share the same code as five's implementation
Ehbw
force-pushed
the
feat/rdr3-block-level-loading
branch
from
1e76291 to
9ac1863
Compare
github-actions
bot
added
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Block Level/Game loading once INIT_CORE has been fully loaded. This matches the behaviour on FiveM while also enabling functionality for
replace_level_metain RedM.How is this PR achieving the goal
By preventing game loading post INIT_CORE until g_callBeforeLoad (set in RageGameInit::LoadGameFirstLaunch returns true on server connection or sp load)
This PR applies to the following area(s)
RedM
Successfully tested on
Game builds: 1436, 1491
Platforms: Windows
Checklist
Fixes issues
https://forum.cfx.re/t/replace-level-meta/4797157