Optimize ACL for faster deletion on resource stop #3414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…identifier comparison by normalizing case
github-actions
bot
added
the
triage
FabianTerhorst
approved these changes
Jun 2, 2025
FabianTerhorst
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How is this PR achieving the goal
Removes the _stricmp that was taking ages by transforming object and principal identifiers to lowercase, uses equal_range in
RemoveAccessControlEntryto avoid looking through all the acesSuccessfully tested on
Platforms: Windows FXServer
Checklist
Fixes issues
fixes #3394