Skip to content

Optimize ACL for faster deletion on resource stop #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

Mathu-lmn
Copy link
Contributor

How is this PR achieving the goal

Removes the _stricmp that was taking ages by transforming object and principal identifiers to lowercase, uses equal_range in RemoveAccessControlEntry to avoid looking through all the aces

Successfully tested on

Platforms: Windows FXServer

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

fixes #3394

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label May 21, 2025
Copy link
Contributor

@FabianTerhorst FabianTerhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot for your contribution.

@FabianTerhorst FabianTerhorst added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Jun 2, 2025
@prikolium-cfx prikolium-cfx merged commit ae8fb34 into citizenfx:master Jun 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ace permissions unregister issue
3 participants