fix(gamestate/server): reimplementation of dd2e1c9#4018
Open
spacevx wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Reimplementation of the commit dd2e1c9
The commit was quickly reverted due to crash issues with peds.
After doing some checks i found out the instance id was wrongly serialized (wrong value)
See screenshots:
The value was checked on dump 1604 & 3258 and it's still 8
How is this PR achieving the goal
By reimplementing the commit and fixing the wrong value
This PR applies to the following area(s)
FiveM
Successfully tested on
Wasn't tested yet, needs to be tested
Game builds: ..
Platforms: Windows, Linux
Checklist
Fixes issues