fix(extra-natives/rdr3): graphic natives flickering#4043
Open
Ehbw wants to merge 2 commits into
Open
Conversation
2aebfb8 to
ced89ef
Compare
ced89ef to
806d428
Compare
Contributor
Author
|
PR has been updated to include fixes to SET_DRAW_ORIGIN to resolve https://forum.cfx.re/t/draworigin-single-frame-positional-issue/5223033 and the flickering regression tied to the previous fix. |
806d428 to
b43f76b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Resolves flickering within several graphic natives (DRAW_BOX/DRAW_POLY/DRAW_LINE) caused by a race condition. This should also resolve several crashes tied to these natives but these crashes were unable to be reproduced. SET_DRAW_ORIGIN has been changed to fix #2450 and the flickering regression reported in #3082
How is this PR achieving the goal
Only allow the game to read imRequests when the main thread has finished for this frame.
This PR applies to the following area(s)
RedM
Successfully tested on
Tested with snippet provided from #4019
Tested with the following settings with/without the changes to confirm it works
SET_DRAW_ORIGIN issue was tested with snippet provided from https://forum.cfx.re/t/draworigin-single-frame-positional-issue/5223033 and #3082 (comment)
Game builds: 1491
Platforms: Windows
Checklist
Fixes issues
fixes #4019
fixes #2450
https://forum.cfx.re/t/draworigin-single-frame-positional-issue/5223033