Unhardcode mail addresses #370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the address where help requests and feedback were sent to was hardcoded to [email protected]. Now it can be configured via the config json.
This address was configurable via the config json and then passed to the e-mail provider, but when actually sending e-mails, a harcoded [email protected] was passed which overrides the configured value. This removes the overrides so the configured value takes effect as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes that prevent hardcoding
@citizenos.come-mail addresses in the source code, both in thefromaddresses for all mails (making the existing config option for this work) and for thetoaddresses for help requests and feedback mails (this adds two new configuration directives).I have tested this on a self-hosted install for the help form. I could not find the feedback form to also test that path (the code suggests that that might be triggered via etherpad, and I have not fully set up the etherpad integration yet).