CLOUD-809: chore(aurora clone lambda) update from python 3.10 to 3.14 - #328
Merged
Merged
Conversation
simonwgill
approved these changes
Jun 29, 2026
simonwgill
left a comment
Contributor
There was a problem hiding this comment.
I don't like that there's no automated tests for this code at all... and that the lambda code can be run under a different runtime than the one used for any static type checking.
But since that's been the case forever and it's not used for any production infrastructure, I guess it's a case of send it, and see if the unlikely case of a failure breaks something.
|
lgtm and thanks for doing this Ruth! |
MrJoosh
approved these changes
Jul 2, 2026
MrJoosh
left a comment
There was a problem hiding this comment.
LGTM - we don't have any clones in cab-data-prod so all good from our side! Thanks Ruth!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Python 3.10 is deprecated - this PR upgrades the lambdas used by the aurora clone mechanism to Python 3.14.
Checklist before requesting a review
I've done a search of citizensadvice github repos, and the only repo that uses the
AuroraCloneRefreshconstruct is casebook (and the now dead witnessbox-v2). This is only in staging/preprod, so we will be able to test before releasing changes to production. I will communicate/manage this with the adviser engineers.EDIT: @mlaycock @Slange-Mhath @MrJoosh I think this PR (once the version of ca-cdk-constructs is updated in the casebook repo) will also fix the EOL lambdas in the cita-devops account for the
qa-DevCasebookDataExtractor. But my AWS permissions don't allow me to see if there are also any aurora clones in the cab-data-prod account445513191207.