fix: Fix duplicate invocation of deprecated onTestFinish callback #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschlat
requested changes
Feb 14, 2025
| @@ -42,7 +42,7 @@ default void onTestFinish(TestCase test) { | |||
| * @see #onTestEnd(TestCase) | |||
| */ | |||
| default void onTestExecutionStart(TestCase test) { | |||
| onTestFinish(test); | |||
| // Default implementation does nothing | |||
There was a problem hiding this comment.
😵
This was a last minute change using copy paste. The correct documentation and implementation should be:
(sorry for not being able to suggest on multiple lines - do not apply as patch)
Suggested change
| // Default implementation does nothing | |
| /** | |
| * Invoked when test execution starts (after {@link org.citrusframework.container.BeforeTest} execution) | |
| */ | |
| default void onTestExecutionStart(TestCase test) { | |
| // Default implementation does nothing | |
| } |
There was a problem hiding this comment.
thank you, I have fixed the javadocs, too. as you have suggested
christophd
force-pushed
the
chore/test-listener-on-finish
branch
from
36d9b4e to
6399728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does it make sense to invoke the deprecated
onTestFinish()in newonTestExecutionStart()? I guess onTestFinish method would be called twice as the newonTestExecutionEnd()does also call the deprecated method, too.