Skip to content

[release-12.1] Quote EXTRACT fields in PG14-16 ruleutils - #8813

Merged
ibrahim halatci (ihalatci) merged 1 commit into
release-12.1from
ihalatci-release-12-quoting-retry
Aug 28, 2026
Merged

[release-12.1] Quote EXTRACT fields in PG14-16 ruleutils#8813
ibrahim halatci (ihalatci) merged 1 commit into
release-12.1from
ihalatci-release-12-quoting-retry

Conversation

@ihalatci

Copy link
Copy Markdown
Contributor

Summary

Backport the focused EXTRACT identifier quoting parity fix from #8804 to release-12.1 for PostgreSQL 14, 15, and 16.

  • quote EXTRACT field identifiers in the copied PG14/PG15/PG16 ruleutils implementations
  • add one shared, repeat-safe extract_deparse regression covering every supported PostgreSQL major
  • run it from release-12's existing current-library multi_1_schedule; this branch predates the N-1 mixed-library schedule split
  • preserve the existing shard-aware Citus deparser changes

Fixes #8803.

Main PR: #8804

Validation

  • -Werror builds against PostgreSQL 14.24, 15.19, and 16.15
  • shared extract_deparse regression: 8/8 repetitions on each supported PostgreSQL major
  • expected output generated with the release-12 regression runner
  • shared SQL matches the main-branch test byte-for-byte; expected output matches the proven release runner output
  • relevant style, schedule, SQL snapshot, and diff checks

Match PostgreSQL's CVE-2026-15741 stable-branch fix by quoting EXTRACT field identifiers in the copied ruleutils implementations. Add one shared, repeat-safe regression in the existing release-12 owning schedule.

Fixes #8803

Backport of #8804

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (377c1f2) to head (956a13f).
⚠️ Report is 17 commits behind head on release-12.1.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-12.1    #8813      +/-   ##
================================================
- Coverage         89.65%   89.64%   -0.01%     
================================================
  Files               276      276              
  Lines             59790    59940     +150     
  Branches           7471     7494      +23     
================================================
+ Hits              53605    53735     +130     
- Misses             4041     4052      +11     
- Partials           2144     2153       +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ihalatci
ibrahim halatci (ihalatci) merged commit a4723c5 into release-12.1 Aug 28, 2026
123 checks passed
@ihalatci
ibrahim halatci (ihalatci) deleted the ihalatci-release-12-quoting-retry branch August 28, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants