Upgrade uncrustify to fix stylechecker images #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2025
colm-mchugh
approved these changes
Dec 8, 2025
colm-mchugh
left a comment
colm-mchugh
left a comment
There was a problem hiding this comment.
Lgtm - covers all uncrustify versions
naisila
force-pushed
the
naisila/update-uncrustify
branch
from
6a5b30d to
9a171d1
Compare
naisila
force-pushed
the
naisila/update-uncrustify
branch
from
9a171d1 to
57f9967
Compare
naisila
changed the title
naisila
added a commit
to citusdata/citus
that referenced
this pull request
Dec 11, 2025
This upgrade has changed some indentation levels, moved some parameter names to the next line etc. I also did some manual style changes to obey the 88-90 character per line rule and avoid commas or semicolons in a new line. Sister PRs citusdata/tools#382 citusdata/the-process#179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades uncrustify to 0.82.0 (see below), downgrades pg versions since we will bump versions in Citus after we fix style images.
Getting the following error with uncrustify 0.68.1:
Fix:
0.78.0 is the oldest version with cmake_minimum_required(VERSION 3.5). However, I suggest going with the newest version of uncrustify, 0.82.0, since were gonna update all things anyway, might as well use the newest version.
Sister PRs citusdata/citus#8373 citusdata/tools#382