CRM-19545 Custom field groups missing from views#405
Open
urlisse wants to merge 1 commit intocivicrm:7.x-masterfrom
urlisse:urlisse-patch-1
Open
CRM-19545 Custom field groups missing from views#405urlisse wants to merge 1 commit intocivicrm:7.x-masterfrom urlisse:urlisse-patch-1
urlisse wants to merge 1 commit intocivicrm:7.x-masterfrom
urlisse:urlisse-patch-1
Conversation
Fix for CRM-19545 : "Custom field groups which do not directly extend the base 'Contact' disappear from Drupal view after applying patch CRM-18776"
monishdeb
requested changes
Nov 4, 2016
| while ($dao->fetch()) { | ||
| // call getTree using $dao->id as groupID, $dao->extends as entityType, with possible subtypes in $dao->extends_entity_column_value | ||
| $extendsContactSubtype = (('Contact' === $dao->extends) && !empty($dao->extends_entity_column_value)); | ||
| $extendsContactSubtype = (in_array($dao->extends, array('Contact', 'Individual', 'Organization', 'Household')) && !empty($dao->extends_entity_column_value)); |
Member
There was a problem hiding this comment.
You can use CRM_Contact_BAO_ContactType::basicTypePairs() instead, which will consider user-defined contact types and sub-types too.
Contributor
There was a problem hiding this comment.
The patch, and this proposed alteration does not fix the issue for custom fields assigned to Relationships. I'll take a look at an alternative solution.
Contributor
There was a problem hiding this comment.
I've updated the issue in JIRA with some additional comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for CRM-19545 : "Custom field groups which do not directly extend the base 'Contact' disappear from Drupal view after applying patch CRM-18776"