Update Command classes for Symfony 7 compatibility (#28)#31
Merged
totten merged 2 commits intocivicrm:masterfrom Nov 1, 2025
Merged
Update Command classes for Symfony 7 compatibility (#28)#31totten merged 2 commits intocivicrm:masterfrom
Command classes for Symfony 7 compatibility (#28)#31totten merged 2 commits intocivicrm:masterfrom
Conversation
…ommand\Command Return Command's constant instead of litaral number.
totten
force-pushed
the
master-symfony-7
branch
from
27b5761 to
a30a1d9
Compare
Member
Author
|
After another little tweak, it's working now. Thanks @emembeka! |
|
I think the configure() function also misses a return type statement. On PHP8.4 (using CiviCRM 6.12) I still get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submission of @emembeka's #29, with re-base for current
master.(Note: We needed some toolchain maintenance (#30 etal). The test-matrix is back up, and it now reproduces the problem of #28 when testing with bleeding-edge version of
composer, i.e. thecomposer self-update --snapshot. Hopefully, with a new run of the PR, we can see that patch fixing the test-failure. 🤞)